naev: fix the build after luajit update#391082
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Mar 20, 2025
Merged
Conversation
On `staging-next` `naev` fails the build as:
../src/lutf8lib.c: In function 'Lutf8_codepoint':
../src/lutf8lib.c:421:22: error: 'INT_MAX' undeclared (first use in this function)
421 | if (pose - posi >= INT_MAX) /* (lua_Integer -> int) overflow? */
| ^~~~~~~
It started after commit a69699e "luajit_2_1: 2.1.1713773202 -> 2.1.1741730670"
which exposed missing include. It's already fixed upstream, but the change is
a bit invasive. Let's settle on header injection.
Merged
13 tasks
Contributor
Author
|
github-actions
bot
added
10.rebuild-darwin: 0
vcunat
approved these changes
Mar 18, 2025
wegank
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
staging-nextnaevfails the build as:It started after commit a69699e "luajit_2_1: 2.1.1713773202 -> 2.1.1741730670" which exposed missing include. It's already fixed upstream, but the change is a bit invasive. Let's settle on header injection.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.