Skip to content

libblake3: 1.6.1 -> 1.7.0; enable TBB multi-threading support#390458

Merged
Ericson2314 merged 3 commits intoNixOS:masterfrom
silvanshade:blake3-tbb
Mar 19, 2025
Merged

libblake3: 1.6.1 -> 1.7.0; enable TBB multi-threading support#390458
Ericson2314 merged 3 commits intoNixOS:masterfrom
silvanshade:blake3-tbb

Conversation

@silvanshade
Copy link
Member

@silvanshade silvanshade commented Mar 16, 2025 •
edited
Loading

This PR updates the version to 1.7.0 and enables recent TBB multi-threading support for libblake3.

  • Built on platform(s)
    • x86_64-linux

@fgaz

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 16, 2025
@silvanshade silvanshade force-pushed the blake3-tbb branch 3 times, most recently from 68b93c5 to aaf1ef6 Compare March 16, 2025 22:45
fgaz
fgaz reviewed Mar 16, 2025
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good except for the comments I left. Also as you write let's wait for a release

@silvanshade silvanshade force-pushed the blake3-tbb branch 3 times, most recently from 005a382 to 9a2c412 Compare March 17, 2025 16:20
fgaz
fgaz reviewed Mar 17, 2025
View reviewed changes
@silvanshade silvanshade marked this pull request as ready for review March 18, 2025 21:31
@silvanshade
Copy link
Member Author

silvanshade commented Mar 18, 2025

@fgaz Release 1.7.0 is published which enables this feature.

@silvanshade
Copy link
Member Author

silvanshade commented Mar 18, 2025 •
edited
Loading

One question I have about the tbb dependency: libblake3 supports at least tbb version 2021_11 but here I've opted to use the latest available in nixpkgs which is 2022_0.

However, I've noticed that version 2022_0 doesn't seem to be available yet for nix (building via the flake), where I intend to use this feature.

I suppose maybe it doesn't matter because nix would still need to update nixpkgs in order to have access to the current libblake3 (or specify a custom local package where it doesn't matter) so at that point the latest tbb should also be available.

Any thoughts on this?

@silvanshade silvanshade changed the title libblake3: enable TBB multi-threading support libblake3: 1.6.1 -> 1.7.0; enable TBB multi-threading support Mar 18, 2025
@silvanshade silvanshade mentioned this pull request Mar 18, 2025
Merged
@Ericson2314 Ericson2314 merged commit fd36cd2 into NixOS:master Mar 19, 2025
57 checks passed
@Ericson2314
Copy link
Member

Ericson2314 commented Mar 19, 2025

@silvanshade You can backport the tbb version you need to 24.11 as a new package. I think that should unblock you?

@fgaz fgaz mentioned this pull request Mar 20, 2025
Merged
13 tasks
@silvanshade silvanshade mentioned this pull request Mar 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgaz fgaz fgaz left review comments

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@silvanshade @Ericson2314 @fgaz