Skip to content

gst_all_1: 1.24.10 → 1.26.0#390268

Merged
jtojnar merged 15 commits intostagingfrom
gst126
Mar 27, 2025
Merged

gst_all_1: 1.24.10 → 1.26.0#390268
jtojnar merged 15 commits intostagingfrom
gst126

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Mar 16, 2025 •
edited
Loading

https://gstreamer.freedesktop.org/releases/1.26/

Things done

  • Skimmed the release notes
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 16, 2025
@jtojnar jtojnar mentioned this pull request Mar 16, 2025
Closed
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@jtojnar jtojnar added this to GNOME 48 Mar 16, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 16, 2025
@jtojnar jtojnar mentioned this pull request Mar 16, 2025
Merged
@jtojnar jtojnar moved this to In Progress in GNOME 48 Mar 16, 2025
@jtojnar

This comment was marked as resolved.

Sign in to view
@jtojnar

This comment was marked as resolved.

Sign in to view
@jtojnar jtojnar marked this pull request as ready for review March 23, 2025 02:28
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 23, 2025
@jtojnar jtojnar force-pushed the gst126 branch 3 times, most recently from 6bd6347 to 1683af5 Compare March 23, 2025 02:36
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 23, 2025
@nix-owners nix-owners bot requested review from bkchr, matthewbauer and ttuegel March 23, 2025 02:44
jtojnar

This comment was marked as resolved.

Sign in to view

@RSWilli RSWilli mentioned this pull request Mar 24, 2025
Closed
3 tasks
@hustlerone

This comment was marked as resolved.

Sign in to view
@jtojnar jtojnar mentioned this pull request Mar 25, 2025
Merged
13 tasks
@jtojnar
orc: 0.4.40 → 0.4.41
0daf808 
https://gitlab.freedesktop.org/gstreamer/orc/-/compare/0.4.40...0.4.41

Also perform some cleanups:

- Dereference `docbook_xsl` alias with `docbook-xsl-nons`.
- Use `finalAttrs` pattern.
- Use `mesonEnable` instead of conditional flags.
- Avoid inheriting from `lib` just for one use each.
- Move `outputs` under `name` and `postPatch` to imperative section.
- Update changelog link to current Git frontend.
jtojnar added 2 commits March 27, 2025 07:01
@jtojnar
gst_all_1.gst-vaapi: 1.24.10 → 1.26.0
7130a71 
- Update https://gstreamer.freedesktop.org/releases/1.26/
- Format expression
- Use `finalAttrs` pattern
- Move `outputs` above `src` for consistency with other GStreamer packages
- Add `updateScript`
@jtojnar
gst_all_1.gst-rtsp-server: 1.24.10 → 1.26.0
c5854a8 
- Update https://gstreamer.freedesktop.org/releases/1.26/
- Format expression
- Use `finalAttrs` pattern
- Move `outputs` above `src` for consistency with other GStreamer packages
- Add `updateScript`
@s0me1newithhand7s s0me1newithhand7s moved this from In Progress to Nice to have in GNOME 48 Mar 27, 2025
@jtojnar jtojnar moved this from Nice to have to Ready in GNOME 48 Mar 27, 2025
@jtojnar
Copy link
Member Author

jtojnar commented Mar 27, 2025

Switched the patches to upstream versions, this should now be good to go.

@jtojnar jtojnar mentioned this pull request Mar 27, 2025
Closed
47 tasks
jtojnar added 6 commits March 27, 2025 11:02
@jtojnar
gst_all_1.gst-plugins-rs: 0.13.3 → 0.13.5
e2edab3 
- Update https://gstreamer.freedesktop.org/releases/1.26/
- Format expression
- Do not take `pname` from `finalAttrs`
@jtojnar
gst_all_1.gst-devtools: 1.24.10 → 1.26.0
a7e5a25 
- Update https://gstreamer.freedesktop.org/releases/1.26/
  - New tool dots-viewer, requires Rust
- Format expression
- Use `finalAttrs` pattern
- Move `outputs` above `src` for consistency with other GStreamer packages
- Add `updateScript`
@jtojnar
gst_all_1.gst-editing-services: 1.24.10 → 1.26.0
8da4265 
- Update https://gstreamer.freedesktop.org/releases/1.26/
- Format expression
- Use `finalAttrs` pattern
- Add `updateScript`
@jtojnar
python3.pkgs.gst-python: 1.24.10 → 1.26.0
cd84653 
- Update https://gstreamer.freedesktop.org/releases/1.26/
- Format expression
- Add `updateScript`
@jtojnar
gst_all_1: Disable GLIB_DEBUG
ed0ddc3 
`glib_debug` option (`gobject-cast-checks` prior to 1.26) defaults to `auto`, which would result in the cast checks being disabled on stable versions, if we did not use `-Dauto_features=enabled`. Let’s disable the option as it is meant to be on stable releases: https://gitlab.gnome.org/GNOME/glib/-/blob/main/docs/macros.md#g_enable_debug

Also remove option disabling `glib_asserts`. It was introduced in 800ceaf to remove references to `dev` output caused by `__FILE__` used in assertions but they no longer seem to appear. While the option supported the `auto` means disabled on stable versions feature, the option was actually enabled by default, so the comment was incorrect.
@jtojnar
python3.pkgs.gst-python: Fix build with PyGObject 3.52
2fcf650 
Still need a second patch for https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4322
@jtojnar jtojnar mentioned this pull request Mar 27, 2025
Closed
13 tasks
@jtojnar jtojnar merged commit 420b54f into staging Mar 27, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in GNOME 48 Mar 27, 2025
@jtojnar jtojnar deleted the gst126 branch March 27, 2025 17:08
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Apr 2, 2025

Hey! This update fails to build:
sys/nvcodec/meson.build:69:4: ERROR: Problem encountered: The nvcodec was enabled explicitly, but required gstcuda dependency is not found, please check!

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Apr 2, 2025

https://gstreamer.freedesktop.org/releases/1.26/
the release notes have some mentions about cuda things and nvcodec. It might however make sense to put that stuff behind the nixpkgs cuda flag and not build with it by default. That'd alleviate the headache of having the patch be potentially breaking for all systems and reduce the risk to only cuda users.

@jtojnar
Copy link
Member Author

jtojnar commented Apr 2, 2025

gst_all_1.gst-plugins-bad built for me on this branch. What system and commit are you building it on?

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Apr 2, 2025 •
edited
Loading

gst_all_1.gst-plugins-bad built for me on this branch. What system and commit are you building it on?

i built it on aarch64-linux on latest staging. That does have some commits of my own against gst-bad which is why i first assumed to have broken it myself, but after explicitly reverting those it still failed.
The exact commit was 15e5151

@mweinelt
Copy link
Member

mweinelt commented Apr 3, 2025

gst-plugins-rs fails in the vendor phase on python-updates

https://hydra.lossy.network/log/xf8gxvpkdzq7rvhx5x7qar40hf0sdp4y-gst-plugins-rs-0.13.5-vendor-staging.drv

@jtojnar
Copy link
Member Author

jtojnar commented Apr 4, 2025

The latter is from mopidy, fix in #395981

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Apr 4, 2025

aarch64 build fixed (bodged) in #395983

@jtojnar
Copy link
Member Author

jtojnar commented Apr 4, 2025 •
edited
Loading

Thanks for fixing that.

Looking at the source, the only reason why gstcuda would not be built on aarch64-linux is this subdir_done call:

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/1.26.0/subprojects/gst-plugins-bad/gst-libs/gst/cuda/meson.build#L55

But I do not see why it would regress, it was already present in 1.24:

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/319f5f07604654b1bf4b58ea416e55324e7d27c4

Howewer, it will be removed in 1.26.1: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/aab14d46e4332046086b0396eac5d450d1437779

This was referenced Apr 17, 2025
Closed
Closed
@OPNA2608 OPNA2608 mentioned this pull request May 6, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@bkchr bkchr Awaiting requested review from bkchr

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

GNOME 48
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtojnar @hustlerone @LordGrimmauld @mweinelt