buildNpmPackage: support finalAttrs through lib.extendMkDerivation#390099
buildNpmPackage: support finalAttrs through lib.extendMkDerivation#390099drupol merged 3 commits intoNixOS:masterfrom
Conversation
This allows using finalAttrs pattern.
|
You might be interested in this pattern: #386757 (comment) |
I prefer doing one thing at one time, unless the tasks are tightly coupled with each other. The overriding improvement using |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
W000000t! |
|
@JohnRTitor: could I requisition you to create the necessary backports to 24.11? |
|
Ah, my dear sir, your request is received with the utmost regard, and I shall attend to the matter with diligence. Pray rest assured that by tomorrow evening, the necessary backports shall be prepared to your satisfaction. |
|
Stop it guys, you crack me up every time I read these kind of comments. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-390099-to-release-24.11 origin/release-24.11
cd .worktree/backport-390099-to-release-24.11
git switch --create backport-390099-to-release-24.11
git cherry-pick -x 70ae16e6bff005ab5ab40090a0dae4b92fad6a57 e6ca2b65cae19e23191213efc04b6341d61947f6 43bf9e325cd1599d88740e4f52f476cf7afad366 |
Inspired from #382550.
Nixfmt is done on the 2nd commit to allow easier commit by commit review.