ofborg hit a different error for Darwin:

> /tmp/nix-build-mudlet-4.19.1.drv-0/source/src/sparkleupdater.mm:23:9: fatal error: 'Sparkle/Sparkle.h' file not found
   >    23 | #import <Sparkle/Sparkle.h>
   >       |         ^~~~~~~~~~~~~~~~~~~
   > 1 error generated.

The breakage on Darwin looks very similar to last time: even though we disable the built-in updater SparkleUpdater, it still seems to include sparkle in the build process. I have tried to override both the USE_UPDATER and WITH_UPDATER flags with no success yet...

Hello! Still working on this?
You might want to apply patch Mudlet/Mudlet@933f255#diff-148715d6ea0c0ea0a346af3f6bd610d010d490eca35ac6a9b408748f7ca9e3f4 to build on cmake4.

• Tracking: Build Failures with CMake 4 #445447

I can take a look at it again, my biggest issue is not having a Mac around to test the darwin build

Feel free to ping me and I can help testing on darwin, I'm interested to try this package. :)

@iedame Applied the patch, if you want to try building that on your side

@iedame Applied the patch, if you want to try building that on your side

CI error likely to GitHub instability, can you re-trigger the CI checks please?

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 389652
Commit: 3cd4f72dc8c32607e501f8e75d46a6e6e67fb3de (subsequent changes)
Merge: 33599ffb039db1e36af388a20a07ca47f29f552d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18750815502

x86_64-linux

✅ No rebuilds

aarch64-linux

✅ No rebuilds

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

I'm running nixpkgs-review but the diff looks really weird with all the commits and it will likely just say no rebuilds. After the results are posted here if you could please squash commits:

• maintainers: add thewanderingcrow
• mudlet: 4.17.2 -> 4.19.1
• mudlet: add maintainer thewanderingcrow

I'm not too certain about how to go about squashing commits, I did some googling but it's looking like it wants me to rebase ~68k commits which doesn't seem right

I'm not too certain about how to go about squashing commits, I did some googling but it's looking like it wants me to rebase ~68k commits which doesn't seem right

Considering this is a very old PR and your first contribution, perhaps we could help in this PR: #451846 instead?
I understand it is a little confusing at first, you will get used to it. For now you can read the CONTRIBUTING.md, it explains many things.

Is it okay if we close this PR and re-open the one by @netcrns that is very recent and ready-to-go? You can open a new PR just adding yourself to the maintainers list and as maintainer to mudlet.

Yeah that's completely fine with me

Nice, thanks! Feel free to ping me when you open the PR to add yourself as maintainer, I can help review it.