Revert "linux: simplify toolchain selection"#389485
Closed
blitz wants to merge 1 commit intoNixOS:stagingfrom
Closed
Revert "linux: simplify toolchain selection"#389485blitz wants to merge 1 commit intoNixOS:stagingfrom
blitz wants to merge 1 commit intoNixOS:stagingfrom
Conversation
This reverts commit 70cc251. This commit actually pulls in GCC for kernel builds in pkgsLLVM. *sigh* Let's accept defeat here and specify everything manually again. An easy way to test this is: build -j2 -A pkgsLLVM.linux_latest.configfile && grep CC_IS result This should always say CLANG and _not_ GCC.
github-actions
bot
added
6.topic: kernel
Contributor
Author
|
Mmh. That's too many rebuilds for nixpkgs-review (HTTP 422 Unprocessable Entity, Mic92/nixpkgs-review#280). What's the proper way of figuring out whether I broke something? |
blitz
requested review from
K900,
RossComputerGuy and
alyssais
and removed request for
alyssais
Contributor
|
Just build the kernels themselves, modules shouldn't break with this kind of thing. |
nix-owners
bot
requested review from
Ma27,
NeQuissimus,
TredwellGit and
thoughtpolice
Contributor
Author
|
Kerne;s built using GCC are fine. I found one issue building This is weird, because |
Contributor
Author
|
Ah, this is cursed. Using |
Contributor
Author
|
Mhh. This is more complicated than I thought. I'll come back with a better PR. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 70cc251.
The reverted commit actually pulls in GCC for kernel builds in pkgsLLVM again. sigh Let's accept defeat here and specify everything manually again. This is a partial revert of apparently broken improvements in #344665.
An easy way to test this is:
This should always say CLANG and not GCC.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.