python2Packages.hypothesis does not eval anyway

Before this PR, python2Packages.hypothesis did eval successfully with allowUnsafe. Hence the patch broke hypothesis on python 2.7, which is unfortunately necessary for some legacy applications (such as gimp2 plugins). Is it okay if I make a PR to revert this patch? 🥺 I know python2 is unsafe (and not evaluated by hydra) but it is still relied on by some old apps, unfortunately...

It doesn't for me, due to dependency on trove-classifiers

$ NIXPKGS_ALLOW_INSECURE=1 nix-shell -I nixpkgs=. -p python2Packages.hypothesis
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:34:12:
           33|
           34|   strict = derivationStrict drvAttrs;
             |            ^
           35|

       … while evaluating derivation 'shell'
         whose name attribute is located at /home/arne/nixpkgs-wt-2/pkgs/stdenv/generic/make-derivation.nix:375:7

       … while evaluating attribute 'buildInputs' of derivation 'shell'
         at /home/arne/nixpkgs-wt-2/pkgs/stdenv/generic/make-derivation.nix:422:7:
          421|       depsHostHost                = elemAt (elemAt dependencies 1) 0;
          422|       buildInputs                 = elemAt (elemAt dependencies 1) 1;
             |       ^
          423|       depsTargetTarget            = elemAt (elemAt dependencies 2) 0;

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: trove-classifiers-2025.1.15.22 not supported for interpreter python2.7

For that matter this PR does not affect eval, only functionality

Ah interesting, so I took a closer look: my dependence of hypothesis is through pytest which actually overrides it to disable tests:

python2Packages.hypothesis.override { doCheck = false; } did evaluate before because it does not depend on trove-classifiers. Is it okay to fix the eval by always setting doCheck = false (and revert this PR)? 🥺

If not, I am fine with maintaining a local fork. I understand that python2 is deprecated.

This PR cannot be reverted, enum34 is gone: #387576

You should probably do a local fork.
Python2 is an entirely neglected part of nixpkgs, and I'm currently doing my best to remove every mention of it that I can find. Especially now that Gimp3 has been released, the reasons to keep anything from Python2 still around are far and few between.

This PR cannot be reverted, enum34 is gone: #387576

I see... I didn't notice because it's in staging and hasn't hit master yet, but now I see that it's only a matter of time... Thanks for the information.

I'm currently doing my best to remove every mention of it that I can find. Especially now that Gimp3 has been released, the reasons to keep anything from Python2 still around are far and few between.

This should be preferred if there is a viable replacement; however, the gimp resynthesizer plugin currently only builds with python2 & gimp2. The gimp3 replacement is still a work in progress, so no replacement viable for the time being.

In any case, I can work with a local fork for now.