Skip to content

nixVersions.latest: 2.25 -> 2.26 #388965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roberth merged 2 commits into from
Mar 17, 2025
Merged

nixVersions.latest: 2.25 -> 2.26 #388965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a59a147
nixVersions.latest: 2.25 -> 2.26
Mic92 Mar 11, 2025
a09345e
nil: don't depend on latest nix version
Mic92 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkgs/by-name/ni/nil/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
lib,
rustPlatform,
fetchFromGitHub,
nixVersions,
nix,
nix-update-script,
}:

Expand All @@ -20,9 +20,7 @@ rustPlatform.buildRustPackage rec {
useFetchCargoVendor = true;
cargoHash = "sha256-7TR/xTc66WpPszJDrpisVvHXl2+FGrUOskZAkGyY04Q=";

nativeBuildInputs = [
(lib.getBin nixVersions.latest)
Copy link
Member Author

@Mic92 Mic92 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxalica please confirm we no longer need this with nix 2.24.

Copy link
Member

@roberth roberth Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @figsoda would also be able to confirm this?

Copy link
Contributor

@drupol drupol Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figsoda is sadly not so active lately.

Copy link
Member

@roberth roberth Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I hope he's well.

I'm willing to assume the removal is ok, considering that it's a build time dependency, and it builds, but let's wait until Monday to give us an opportunity to handle this issue without potential for a minor(?) regression.

Copy link
Contributor

@oxalica oxalica Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxalica please confirm we no longer need this with nix 2.24.

Sorry for the late response. As mentioned by @roberth, yes this is a build-time dependency to populate the builtin function list. As long as it builds, it's good.

];
nativeBuildInputs = [ nix ];

env.CFG_RELEASE = version;

Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/package-management/nix/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ in lib.makeExtensible (self: ({
self_attribute_name = "git";
};

latest = self.nix_2_25;
latest = self.nix_2_26;

# The minimum Nix version supported by Nixpkgs
# Note that some functionality *might* have been backported into this Nix version,
Expand Down