Skip to content

nixVersions.latest: 2.25 -> 2.26#388965

Merged
roberth merged 2 commits intoNixOS:masterfrom
Mic92:nix-version-latest
Mar 17, 2025
Merged

nixVersions.latest: 2.25 -> 2.26#388965
roberth merged 2 commits intoNixOS:masterfrom
Mic92:nix-version-latest

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 11, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 mentioned this pull request Mar 11, 2025
Merged
16 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 11, 2025
@nix-owners nix-owners bot requested review from Artturin and lovesegfault March 11, 2025 12:33
@Mic92
nil: don't depend on latest nix version
a09345e 
I think this was added when we didn't had nix 2.24 as the default.
I don't think this should be needed anymore?
Mic92
Mic92 commented Mar 11, 2025
View reviewed changes
pkgs/by-name/ni/nil/package.nix
cargoHash = "sha256-7TR/xTc66WpPszJDrpisVvHXl2+FGrUOskZAkGyY04Q=";

nativeBuildInputs = [
(lib.getBin nixVersions.latest)
Copy link
Member Author

@Mic92 Mic92 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxalica please confirm we no longer need this with nix 2.24.

Copy link
Member

@roberth roberth Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @figsoda would also be able to confirm this?

Copy link
Contributor

@drupol drupol Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figsoda is sadly not so active lately.

Copy link
Member

@roberth roberth Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I hope he's well.

I'm willing to assume the removal is ok, considering that it's a build time dependency, and it builds, but let's wait until Monday to give us an opportunity to handle this issue without potential for a minor(?) regression.

Copy link
Contributor

@oxalica oxalica Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oxalica please confirm we no longer need this with nix 2.24.

Sorry for the late response. As mentioned by @roberth, yes this is a build-time dependency to populate the builtin function list. As long as it builds, it's good.

@nix-owners nix-owners bot requested review from figsoda and oxalica March 11, 2025 12:45
drupol
drupol approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 12, 2025
@roberth roberth merged commit ca1f226 into NixOS:master Mar 17, 2025
28 checks passed
@roberth
Copy link
Member

roberth commented Mar 17, 2025

@oxalica we've adjusted nil's nativeBuildInputs. See https://github.com/NixOS/nixpkgs/pull/388965/files#r1989167399

@Mic92 Mic92 deleted the nix-version-latest branch March 19, 2025 22:37
@emilazy
Copy link
Member

emilazy commented Mar 24, 2025

pkgsStatic.nixVersions.latest (or any other cross) throws at eval time with error: attribute should be found now because of some bug in the 2.26 derivation’s splicing code.

@Mic92 Mic92 mentioned this pull request Mar 24, 2025
Closed
3 tasks
@Mic92
Copy link
Member Author

Mic92 commented Mar 24, 2025

Cross-compilation tracked in #392783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drupol drupol drupol approved these changes

@tomberek tomberek Awaiting requested review from tomberek

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@edolstra edolstra Awaiting requested review from edolstra

@roberth roberth Awaiting requested review from roberth

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@Artturin Artturin Awaiting requested review from Artturin

@oxalica oxalica Awaiting requested review from oxalica

@figsoda figsoda Awaiting requested review from figsoda

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mic92 @roberth @emilazy @drupol @oxalica @wegank