Skip to content

Revert "emacs: enable __structuredAttrs by default in elisp build hel…#388912

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/elisp-__structuredAttrs-tmp-revert
Mar 11, 2025
Merged

Revert "emacs: enable __structuredAttrs by default in elisp build hel…#388912
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/elisp-__structuredAttrs-tmp-revert

Conversation

@jian-lin
Copy link
Contributor

…pers"

This reverts commit d64a233.

A stdenv bug breaks emacs.pkgs.withPackages wrapper. A fix PR1 will take a few weeks to reach users because it has to go through a staging cycle. Revert this for now to unbreak emacs.pkgs.withPackages wrapper.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

…pers"

This reverts commit d64a233.

A stdenv bug breaks emacs.pkgs.withPackages wrapper.  A fix PR[1] will
take a few weeks to reach users because it has to go through a staging
cycle.  Revert this for now to unbreak emacs.pkgs.withPackages
wrapper.

[1]: NixOS#388908
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 6.topic: emacs Text editor 8.has: documentation This PR adds or changes documentation labels Mar 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 11, 2025
@jian-lin jian-lin merged commit 5f385ba into NixOS:master Mar 11, 2025
26 of 27 checks passed
@jian-lin jian-lin deleted the pr/elisp-__structuredAttrs-tmp-revert branch March 11, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant