You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
@GaetanLepage We should not merge PRs that change the upstream source of a package without justification in the commit/PR message and scrutiny from reviewers, especially if the source is controlled by the person opening the PR!
@GaetanLepage We should not merge PRs that change the upstream source of a package without justification in the commit/PR message and scrutiny from reviewers, especially if the source is controlled by the person opening the PR!
This was definitely an oversight on my end. Sorry for missing this one :/
@GaetanLepage We should not merge PRs that change the upstream source of a package without justification in the commit/PR message and scrutiny from reviewers, especially if the source is controlled by the person opening the PR!
Hi, this is entirely my fault, not @GaetanLepage . I didn't explain why this change was made, and there was no bad intention on my part. Here are the reasons for the change:
1/ The Git repo was no longer accessible
2/ When it was accessible, i.e., about 15 days earlier, it wasn't up to date
3/ There were strong suspicions that this Git repo had been deleted
That's why I changed the link.
Sorry if this was a problem I should have asked.
PS: Currently, even the Git repo on Tor is no longer available; only my repo remains.
@GaetanLepage We should not merge PRs that change the upstream source of a package without justification in the commit/PR message and scrutiny from reviewers, especially if the source is controlled by the person opening the PR!
Hi, this is entirely my fault, not @GaetanLepage . I didn't explain why this change was made, and there was no bad intention on my part. Here are the reasons for the change: 1/ The Git repo was no longer accessible 2/ When it was accessible, i.e., about 15 days earlier, it wasn't up to date 3/ There were strong suspicions that this Git repo had been deleted That's why I changed the link. Sorry if this was a problem I should have asked. PS: Currently, even the Git repo on Tor is no longer available; only my repo remains.
Best Regards
Thanks for the additional context. However, I should definitely have noticed such a change and pushed back. I have some responsibility too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
liberodark
changed the title
github-actions
bot
added
10.rebuild-darwin: 0
Fix : #374238
Please backport this PR because is fix issue for Joycon on 24.11 too.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.