[staging-next] samsung-unified-linux-driver: fix library path, with lib;, finalAttrs#388732
Merged
SuperSandro2000 merged 4 commits intoNixOS:staging-nextfrom Mar 10, 2025
Conversation
Change the name of the derivation in `pkgs/misc/cups/drivers/samsung/4.01.17.nix` from "samsung-UnifiedLinuxDriver" to "samsung-unified-linux-driver", so that it matches the names of the other versions declared in `pkgs/misc/cups/drivers/samsung/1.00.37.nix` and in `pkgs/by-name/sa/samsung-unified-linux-driver_1_00_36/package.nix`.
On x86-64, the executables were looking for
libraries in `${lib.getLib stdenv.cc.cc}/lib64`,
but that path apparently changed with
NixOS@5e2e98f ,
resulting in a runtime error:
> /nix/store/0z8gd4fmjknwswx0pp5kzqnrhj1k9q8x-samsung-UnifiedLinuxDriver-4.01.17/lib/cups/filter/rastertospl: error while loading shared libraries: libstdc++.so.6: cannot open shared object file: No such file or directory
Affected programs are
`$out/lib/cups/filter/{ps,raster}tospl{,c}`.
The commit at hand fixes the library lookup path.
github-actions
bot
added
6.topic: printing
SuperSandro2000
changed the title
samsung-unified-linux-driver: fix library path, with lib;, finalAttrswith lib;, finalAttrs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#380325 changed some library paths in
stdenv.cc.cc.samsung-unified-linux-driverv4.01.17 uses these paths to findlibstdc++.so(and possibly more), and thus got broken by that change.The pull request at hand adapts the build recipe of
samsung-unified-linux-driverto use the new paths. It also renames the derivation (nameattribute) so that it matches the names of the othersamsung-unified-linux-driverversions.Furthermore, it removes
with lib;frommetaand replacesrecwith thefinalAttrspattern in all threesamsung-unified-linux-driverderivations.Notifying maintainer of newest version (the other versions have no maintainer): @jokogr
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.