Skip to content

gleam: 1.8.1 -> 1.9.1#388476

Merged
happysalada merged 1 commit intoNixOS:staging-nextfrom
llakala:gleam-1.9
Mar 10, 2025
Merged

gleam: 1.8.1 -> 1.9.1#388476
happysalada merged 1 commit intoNixOS:staging-nextfrom
llakala:gleam-1.9

Conversation

@llakala
Copy link
Contributor

@llakala llakala commented Mar 9, 2025 •
edited
Loading

We add new dependencies for the new echo tests. See gleam-lang/gleam#4316. We also target staging-next to rely on Rust 1.85.

Marking as draft for now, because I'm still getting one failed test that I'm not sure the cause of.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 6.topic: php PHP is a general-purpose scripting language geared towards web development. 6.topic: deepin 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Mar 9, 2025
@llakala
Copy link
Contributor Author

llakala commented Mar 9, 2025

Oops, targeted the wrong branch.

@llakala llakala changed the title gleam: 1.8.1 0> 1.9 gleam: 1.8.1 -> 1.9 Mar 9, 2025
@llakala llakala changed the base branch from master to staging-next March 9, 2025 17:18
@github-actions github-actions bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Mar 9, 2025
@github-actions github-actions bot added the 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. label Mar 9, 2025
@llakala
Copy link
Contributor Author

llakala commented Mar 9, 2025

I doubt that's true, Github Actions.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 9, 2025
@llakala
Copy link
Contributor Author

llakala commented Mar 9, 2025 •
edited
Loading

As you'll see by the checks, it seems to be passing. However, it wasn't building until I added checkFlags = [ "RUST_BACKTRACE=1" ]. Before, it was giving me:

       > thread 'tests::echo::echo_dict' panicked at test-output/src/tests/echo.rs:64:6:
       > run setup: DependencyResolutionFailed("Unable to determine package versions: error sending request for url (https://repo.hex.pm/packages/gleam_stdlib)")

I'm undrafting this for now, because it does seem to work, but I don't know why that made it work. If anyone could help me figure out why, and if there's a better fix, I'd appreciate it.

@llakala llakala marked this pull request as ready for review March 9, 2025 20:40
@happysalada
Copy link
Contributor

happysalada commented Mar 10, 2025

It looks like that test is making a network request, please disable it.

@llakala llakala changed the title gleam: 1.8.1 -> 1.9 gleam: 1.8.1 -> 1.9.1 Mar 10, 2025
@llakala
Copy link
Contributor Author

llakala commented Mar 10, 2025

1.9.1 has since been released (relevant changelog here), so I bumped the version to it, and disabled the mentioned test.

@happysalada happysalada merged commit 4273cbb into NixOS:staging-next Mar 10, 2025
35 checks passed
@happysalada
Copy link
Contributor

happysalada commented Mar 10, 2025

Thank you !

@llakala llakala mentioned this pull request Mar 10, 2025
Closed
3 tasks
@llakala llakala deleted the gleam-1.9 branch March 10, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbigras bbigras Awaiting requested review from bbigras

@yurrriq yurrriq Awaiting requested review from yurrriq

@gleber gleber Awaiting requested review from gleber

@minijackson minijackson Awaiting requested review from minijackson

@DianaOlympos DianaOlympos Awaiting requested review from DianaOlympos

@PhilTaken PhilTaken Awaiting requested review from PhilTaken

@happysalada happysalada Awaiting requested review from happysalada

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@ankhers ankhers Awaiting requested review from ankhers

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@llakala @happysalada