Merged
Conversation
13 tasks
github-actions
bot
added
10.rebuild-darwin: 501+
Contributor
|
IMO just yeet the conditional and the package in the same PR. We don't need that thing around. |
marcin-serwin
force-pushed
the
push-vwmxlrtpvtxo
branch
from
f25d415 to
7a4e2d4
Compare
marcin-serwin
changed the title
K900
reviewed
Mar 9, 2025
| "-Dgl_winsys=${lib.concatStringsSep "," (lib.optional enableX11 "x11" ++ lib.optional enableWayland "wayland" ++ lib.optional enableCocoa "cocoa")}" | ||
| (lib.mesonEnable "introspection" withIntrospection) | ||
| (lib.mesonEnable "doc" enableDocumentation) | ||
| (lib.mesonEnable "libvisual" false) |
Contributor
There was a problem hiding this comment.
Should be fine to remove this line now.
Contributor
Author
There was a problem hiding this comment.
I think it's enabled by default, but I'll double check
Contributor
Author
There was a problem hiding this comment.
Yep, without this line building gst-plugins-base fails with
Run-time dependency libvisual-0.4 found: NO (tried pkgconfig)
ext/libvisual/meson.build:6:16: ERROR: Dependency "libvisual-0.4" not found, tried pkgconfig
This was referenced Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #384912
The
libvisualseems to be largely unused. It's already disabled on Arch Linux, and thelibvisualitself is not even packaged in their repo.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.