SDL_compat: symlink package config specification file into sdl.pc#388304
Merged
K900 merged 1 commit intoNixOS:masterfrom Mar 9, 2025
Merged
SDL_compat: symlink package config specification file into sdl.pc#388304K900 merged 1 commit intoNixOS:masterfrom
K900 merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
SuperSandro2000
changed the title
LordGrimmauld
force-pushed
the
sdl_compat_prep
branch
from
b93968f to
17ae41b
Compare
SuperSandro2000
approved these changes
Mar 8, 2025
Contributor
Author
|
running nixpkgs-review currently. This only caused ~25 rebuilds, none of which actually use |
Contributor
Author
|
K900
reviewed
Mar 9, 2025
LordGrimmauld
force-pushed
the
sdl_compat_prep
branch
from
17ae41b to
aa8bb53
Compare
Contributor
Author
|
I also tested this PR against #384912 switching back to |
13 tasks
13 tasks
LordGrimmauld
added a commit
to LordGrimmauld/nixpkgs
that referenced
this pull request
Mar 26, 2025
Previously, replacing SDL2 with sdl2-compat with dependents on the SDL2 pkgconfig file would just break.
An example for this breakage is pkgs.ffmpeg.override { SDL2 = pkgs.sdl2-compat; }.
This is fixed by symlinking the missing sdl2.pc file to point to sdl2_compat.pc.
This is analogous to NixOS#388304 (aa8bb53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, replacing SDL with SDL_compat with dependents on the SDL pkgconfig file would just break.
An example for this breakage is
pkgs.quirc.override { SDL = pkgs.SDL_compat; }. This PR aims to fix this by symlinking the missingsdl.pcfile to point tosdl12_compat.pcinstead.DISCLAIMER: I have no idea how many rebuilds this will cause, this might well be a mass rebuild in which case i'll need to rebase against staging. Opening this PR early partially to track and see rebuild count.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.