libqmi: unbreak cross compilation#388297
Merged
uninsane merged 1 commit intoNixOS:stagingfrom Mar 9, 2025
Merged
Conversation
ofborg
bot
added
the
6.topic: cross-compilation
github-actions
bot
added
10.rebuild-darwin: 1-10
marcin-serwin
force-pushed
the
push-yznwlxkvoztq
branch
from
80b8fbd to
6f0a6af
Compare
misuzu
reviewed
Mar 9, 2025
With meson 1.7.0 files needed for testing are not built by default [1]. `libqmi` has incorrectly configured dependencies for gtk-doc generation thus they are not built unless tests are run [2]. Since check phase is skipped for cross compiling this was causing the build failures, while the regular builds were unaffected. Setting `doCheck` to false will cause the install phase to fail also when compiling the package natively. [1]: https://mesonbuild.com/Release-notes-for-1-7-0.html#test-targets-no-longer-built-by-default [2]: https://gitlab.freedesktop.org/mobile-broadband/libqmi/-/issues/124
marcin-serwin
force-pushed
the
push-yznwlxkvoztq
branch
from
6f0a6af to
1c1aba7
Compare
misuzu
approved these changes
Mar 9, 2025
Contributor
misuzu
left a comment
misuzu
left a comment
There was a problem hiding this comment.
Fixes the pkgsCross.riscv64.libqmi for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
meson1.7.0 files needed for testing are not built by default 1.libqmihas incorrectly configured dependencies for gtk-doc generation thus they are not built unless tests are run 2. Since check phase is skipped for cross compiling this was causing the build failures, while the regular builds were unaffected. SettingdoCheckto false will cause the install phase to fail also when compiling the package natively.Fixes #384946
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.