treewide: replace references to SDL*.dev with lib.getDev and lib.getInclude#388253
Merged
K900 merged 2 commits intoNixOS:masterfrom Mar 8, 2025
Merged
treewide: replace references to SDL*.dev with lib.getDev and lib.getInclude#388253K900 merged 2 commits intoNixOS:masterfrom
K900 merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: python
Contributor
Author
|
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an overlay replacing
SDLwithSDL_compatcurrently fails, becauseSDL_compathas nodevoutput, yet some dependents assumeSDL.devto exist.Calling
lib.getDevbypasses this issue by returning.devif it exists, and otherwise falling back toout.This change causes no rebuilds, meaning it also does not break anything.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.