Skip to content

python312Packages.raylib-python-cffi: fix build, add passthru tests#387993

Merged
GaetanLepage merged 2 commits intoNixOS:masterfrom
Sigmanificient:raylib-cffi-fix
Mar 30, 2025
Merged

python312Packages.raylib-python-cffi: fix build, add passthru tests#387993
GaetanLepage merged 2 commits intoNixOS:masterfrom
Sigmanificient:raylib-cffi-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Mar 7, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 7, 2025
@Sigmanificient
Copy link
Member Author

image

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 7, 2025
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Mar 13, 2025

image
image

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387993


x86_64-linux

✅ 4 packages built:
  • python312Packages.raylib-python-cffi
  • python312Packages.raylib-python-cffi.dist
  • python313Packages.raylib-python-cffi
  • python313Packages.raylib-python-cffi.dist

aarch64-darwin

✅ 4 packages built:
  • python312Packages.raylib-python-cffi
  • python312Packages.raylib-python-cffi.dist
  • python313Packages.raylib-python-cffi
  • python313Packages.raylib-python-cffi.dist

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 13, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2298

@GaetanLepage GaetanLepage merged commit ef64e3a into NixOS:master Mar 30, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants