Skip to content

treefmt1: remove#387745

Merged
zimbatm merged 1 commit intoNixOS:masterfrom
jfly:remove-treefmt1
Mar 8, 2025
Merged

treefmt1: remove#387745
zimbatm merged 1 commit intoNixOS:masterfrom
jfly:remove-treefmt1

Conversation

@jfly
Copy link
Contributor

@jfly jfly commented Mar 6, 2025

treefmt2 is stable, and treefmt1 hasn't been maintained for a while now. Let's get rid of it!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jfly jfly force-pushed the remove-treefmt1 branch from 0e85c54 to ab2ceba Compare March 6, 2025 22:31
@jfly jfly requested review from brianmcgee and zimbatm March 6, 2025 22:31
@nim65s nim65s self-requested a review March 7, 2025 11:57
Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eval fails in nixfmt-tree:

error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "treefmt2" at /nix/store/qgdcazqs1w3bijqwij0xw714li1gjsiq-source/pkgs/by-name/ni/nixfmt-tree/package.nix:7, did you mean "treefmt"?'

`treefmt2` is stable, and `treefmt1` hasn't been maintained for a while now.
Let's get rid of it!
@jfly
Copy link
Contributor Author

jfly commented Mar 7, 2025

eval fails in nixfmt-tree:

Fixed! (I think)

@jfly jfly force-pushed the remove-treefmt1 branch from ab2ceba to 063749f Compare March 7, 2025 17:57
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 7, 2025
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 8, 2025
@zimbatm zimbatm merged commit dcb250a into NixOS:master Mar 8, 2025
28 checks passed
@jfly jfly deleted the remove-treefmt1 branch March 8, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants