Skip to content

python3Packages.enum34: remove#387576

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bengsparks:enum34
Mar 12, 2025
Merged

python3Packages.enum34: remove#387576
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
bengsparks:enum34

Conversation

@bengsparks
Copy link
Contributor

Completes / Closes #349607.
Supersedes / Closes #349611.

The last occurrence of enum34 was removed on staging, so this must also target staging.

$ nix-build -A python3Packages.enum34
     error: enum34 is no longer needed since Python 3.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 6, 2025
@nix-owners nix-owners bot requested a review from natsukium March 6, 2025 12:14
@bengsparks bengsparks mentioned this pull request Mar 6, 2025
21 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 6, 2025
@bengsparks
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 387576

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage requested a review from NickCao March 12, 2025 16:03
@SuperSandro2000
Copy link
Member

finally

@SuperSandro2000 SuperSandro2000 merged commit c3acc2b into NixOS:staging Mar 12, 2025
27 checks passed
@bengsparks bengsparks deleted the enum34 branch March 12, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants