gst_all_1.gst-plugins-bad: disable DirectFB#387419
Merged
K900 merged 1 commit intoNixOS:stagingfrom Mar 12, 2025
Merged
Conversation
fpletz
approved these changes
Mar 5, 2025
Member
fpletz
left a comment
fpletz
left a comment
There was a problem hiding this comment.
LGTM, let's wait for ofborg. :)
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
LordGrimmauld
approved these changes
Mar 10, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Diff looks good and ofborg is happy. This is also one of the few paths in which SDL1 causes mass-rebuilds (sdl -> directfb -> gst -> gtk -> ...) and i am happy to have less things pull in SDL1. Good work!
wegank
added
12.approvals: 2
Contributor
|
Same question as before: do we really need to expose an option for that? |
marcin-serwin
force-pushed
the
push-lxmmrwovzmrm
branch
from
3caf415 to
49551b4
Compare
Contributor
Author
Most likely not, removed. |
Contributor
There was a problem hiding this comment.
It would make sense to move this up to he non-conditional list instead of having this in the middle between conditionals. E.g. under (lib.mesonEnable "doc" enableDocumentation).
marcin-serwin
force-pushed
the
push-lxmmrwovzmrm
branch
from
49551b4 to
c31d450
Compare
DirectFB had no point release for 11 years now and is probably unused by the majority of users, yet it's a transitive dependency of many packages due to being used in gst-plugins-bad. This plugin has been disabled in Arch for 5 years now <https://gitlab.archlinux.org/archlinux/packaging/packages/gst-plugins-bad/-/commit/899fb518af27d82a9b07a2b341cd55edba1575b9#9b9baac1eb9b72790eef5540a1685306fc43fd6c_59_40> and it will be disabled in the next Debian release: <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083040> so this change should be fairly safe.
marcin-serwin
force-pushed
the
push-lxmmrwovzmrm
branch
from
c31d450 to
019bbf2
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
LordGrimmauld
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectFB had no point release for 11 years now and is probably unused by the majority of users, yet it's a transitive dependency of many packages due to being used in gst-plugins-bad. This plugin has been disabled in Arch for 5 years now
https://gitlab.archlinux.org/archlinux/packaging/packages/gst-plugins-bad/-/commit/899fb518af27d82a9b07a2b341cd55edba1575b9#9b9baac1eb9b72790eef5540a1685306fc43fd6c_59_40 and it will be disabled in the next Debian release: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083040 so this change should be fairly safe.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.