emacs: support and enable __structuredAttrs in elisp build helpers#387193
emacs: support and enable __structuredAttrs in elisp build helpers#387193jian-lin merged 4 commits intoNixOS:masterfrom
Conversation
This is compatible with __structuredAttrs.
|
After a recent update(nix flake update), my Emacs configuration is failing to load. I'm getting errors indicating missing dependencies for several packages:
In the latest nixpkgs-unstable, My configuration: emacsPkg = pkgs.emacsWithPackagesFromUsePackage {
config = ./emacs/init.el;
defaultInitFile = true;
package = pkgs.emacs-unstable.override {
withNativeCompilation = false;
};
alwaysEnsure = false;
alwaysTangle = true;
extraEmacsPackages =
epkgs: with epkgs; [
treesit-grammars.with-all-grammars
];
};;; Magit additional configurations
(use-package magit
:ensure t
:bind (:map magit-status-mode-map
("C-M-<up>" . magit-section-up))
:config
(when *is-a-mac*
(add-hook 'magit-mode-hook (lambda () (local-unset-key [(meta h)])))))Those errors was gone after I pin nixpkgs to a398296 |
|
Could you provide a minimal reproducing example (in a new issue, ideally)? I do not see your |
|
OK, I understand. I'll add an example later. |
environment.systemPackages = [
(
pkgs.emacsWithPackagesFromUsePackage {
config = ./emacs/init.el;
defaultInitFile = true;
alwaysEnsure = false;
alwaysTangle = true;
extraEmacsPackages =
epkgs: with epkgs; [
treesit-grammars.with-all-grammars
];
};
)
];
(use-package magit
:ensure t
:config
(setq-default magit-diff-refine-hunk 'all)Edit: The Emacs package itself doesn't seem to be the issue. This error occurs with pkgs.emacs, pkgs.emacs-unstable, and pkgs.emacs-git. |
|
emacs-overlay and nixpkgs commit hash? |
|
nixpkgs: 2d9e445 |
|
Thanks for the report. |
|
Hi. Any idea how a dependency can be added to an emacs package after this change? I used to have: But now it doesn't work. If I got it right |
|
@kurnevsky See my comments in #388829 |
A step towards #205690.
This PR does not cause new elisp build failures.
FYI, this is the motivation of
__structuredAttrs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.