sdl2-compat: 2.30.52 -> 2.32.52#386759
Merged
donovanglover merged 1 commit intoNixOS:masterfrom Mar 8, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
nadiaholmquist
approved these changes
Mar 3, 2025
wegank
added
12.approvals: 1
Member
|
Member
|
error: builder for '/nix/store/j6rlvy0w57g1szbd2qys27h5r759gnkm-sdl2-compat-2.32.52.drv' failed with exit code 1;
last 25 log lines:
> Start 10: testthread
> 7/13 Test #9: testqsort ........................ Passed 0.03 sec
> Start 11: testtimer
> 8/13 Test #11: testtimer ........................***Failed 0.74 sec
> 2025-03-04 15:28:08.665 testtimer[39443:84722] Sanity-checking GetTicks
> 2025-03-04 15:28:09.335 testtimer[39443:84722] ERROR: testtimer.c: Delta time erratic at iter 192. Delay 1ms = 101 ms in ticks, 101 ms in ticks64
>
> Start 12: testver
> 9/13 Test #12: testver .......................... Passed 0.02 sec
> Start 13: testautomation
> 10/13 Test #2: testerror ........................ Passed 5.69 sec
> 11/13 Test #1: testatomic ....................... Passed 7.96 sec
> 12/13 Test #10: testthread ....................... Passed 10.99 sec
> 13/13 Test #13: testautomation ................... Passed 12.91 sec
>
> 92% tests passed, 1 tests failed out of 13
>
> Total Test time (real) = 13.80 sec
>
> The following tests FAILED:
> 11 - testtimer (Failed)
> Errors while running CTest
> FAILED: CMakeFiles/test.util
> cd /tmp/nix-build-sdl2-compat-2.32.52.drv-0/source/build && /nix/store/09z9lbk25n46m7fb6snmsf2hipqw45pp-cmake-3.31.5/bin/ctest --force-new-ctest-process
> ninja: build stopped: subcommand failed. |
Contributor
|
I can't reproduce that, though I'm trying it on aarch64-darwin building the x86_64-darwin package. Perhaps this bit in the SDL3 package is relevant? |
Contributor
This seems unrelated, it's about tests timing out, this one is just failing.
I was able to reproduce it using GitHub Actions: Looking at the failing test's code, it just sleeps for 1ms and checks that less than 100ms passed after wake up. Given that OSs give no guarantee about the sleep duration it's entirely possible that this test fails for no reason. The GitHub actions machines are likely under a heavy load, being shared among GitHub users, so it's reasonable that the OS will give low priority to the tests thus making the sleeps take too long. Unless someone can reproduce it on their own machine under a normal load I would ignore it. |
marcin-serwin
approved these changes
Mar 8, 2025
donovanglover
added
12.approvals: 2
13 tasks
marcin-serwin
added a commit
to marcin-serwin/nixpkgs
that referenced
this pull request
Mar 13, 2025
The slow tests rely on timers executing within a specified time which is not necessarily true if system is under a heavy load [1]. These tests are also disabled in the official CI pipeline [2]. [1]: NixOS#386759 (comment) [2]: https://github.com/libsdl-org/sdl2-compat/blob/9544651fb39deefb2dd1aed9113af3b60898a1bb/.github/workflows/main.yml#L116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/libsdl-org/sdl2-compat/releases/tag/release-2.32.52
requires #383127 for build
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.