checkpolicy: remove meta.name and add main program#385646
Merged
RossComputerGuy merged 1 commit intoNixOS:masterfrom Mar 5, 2025
Merged
checkpolicy: remove meta.name and add main program#385646RossComputerGuy merged 1 commit intoNixOS:masterfrom
RossComputerGuy merged 1 commit intoNixOS:masterfrom
Conversation
RossComputerGuy
force-pushed
the
fix/checkpolicy-eval
branch
from
4b99136 to
bdef187
Compare
github-actions
bot
added
10.rebuild-darwin: 0
bengsparks
approved these changes
Feb 27, 2025
Contributor
bengsparks
left a comment
bengsparks
left a comment
There was a problem hiding this comment.
I was able to reproduce the behavior, and can confirm that the warning disappears after applying this patch. Many thanks!
RossComputerGuy
added
the
12.approvals: 1
bengsparks
added
12.approvals: 2
Contributor
|
@GaetanLepage could this be backported? It's a package correction that doesn't change the hash, so it should be safe right? |
Contributor
Yes, it seems legible for a backport. I added the label. |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Fixes the eval in #383882, this can be reproduced via
lib.getExe pkgs.checkpolicy.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.