Skip to content

sdl3: 3.2.2 -> 3.2.6, fix version regex#383127

Merged
donovanglover merged 1 commit intoNixOS:masterfrom
nadiaholmquist:sdl3-3.2.4
Mar 4, 2025
Merged

sdl3: 3.2.2 -> 3.2.6, fix version regex#383127
donovanglover merged 1 commit intoNixOS:masterfrom
nadiaholmquist:sdl3-3.2.4

Conversation

@nadiaholmquist
Copy link
Contributor

@nadiaholmquist nadiaholmquist commented Feb 18, 2025

Updates SDL3 to 3.2.6, see changelog: https://github.com/libsdl-org/SDL/releases/tag/release-3.2.6

Also fixes the version regex for the update script, the single quotes around the regex seemed to make it not match anything, and I also added the first 3 explicitly so it won't try to "update" it to newer SDL2 releases from the same repo.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 18, 2025
@nix-owners nix-owners bot requested a review from getchoo February 18, 2025 15:15
@marcin-serwin
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383127


x86_64-linux

✅ 5 packages built:
  • sdl2-compat
  • sdl2-compat.dev
  • sdl3
  • sdl3.dev
  • sdl3.lib

aarch64-linux

✅ 5 packages built:
  • sdl2-compat
  • sdl2-compat.dev
  • sdl3
  • sdl3.dev
  • sdl3.lib

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 25, 2025
@marcin-serwin
Copy link
Contributor

@nadiaholmquist nadiaholmquist changed the title sdl3: 3.2.2 -> 3.2.4, fix version regex sdl3: 3.2.2 -> 3.2.6, fix version regex Mar 2, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 3, 2025
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump! Everything here LGTM

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 3, 2025
@MisileLab MisileLab mentioned this pull request Mar 3, 2025
13 tasks
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 3, 2025
@donovanglover donovanglover merged commit 95a0934 into NixOS:master Mar 4, 2025
46 checks passed
@marcin-serwin marcin-serwin mentioned this pull request Mar 4, 2025
13 tasks
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 5, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants