Skip to content

pkgs-lib: Make tests independent of Nix file contents#382880

Merged
h7x4 merged 1 commit intoNixOS:masterfrom
tweag:pkgs-lib-tests-nix-independent
Feb 24, 2025
Merged

pkgs-lib: Make tests independent of Nix file contents#382880
h7x4 merged 1 commit intoNixOS:masterfrom
tweag:pkgs-lib-tests-nix-independent

Conversation

@infinisil
Copy link
Member

Before, all of these tests would be rebuilt whenever formats.nix is modified, but there's no need for this :)

Things done

  • Tested nix-build -A tests.pkgs-lib

This work is funded by Antithesis and Tweag

Add a 👍 reaction to pull requests you find important.

Before, all of these tests would be rebuilt whenever formats.nix is
modified, but there's no need for this :)
@nix-owners nix-owners bot requested review from Stunkymonkey and h7x4 February 17, 2025 17:45
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 17, 2025
Copy link
Contributor

@Stunkymonkey Stunkymonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stunkymonkey
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382880


x86_64-linux

✅ 1 package built:
  • tests.pkgs-lib

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 18, 2025
@h7x4 h7x4 merged commit 2312049 into NixOS:master Feb 24, 2025
29 checks passed
@infinisil infinisil deleted the pkgs-lib-tests-nix-independent branch February 24, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants