Revert "lib.types.attrsWith: remove failing test"#382856
Merged
hsjobeki merged 1 commit intoNixOS:masterfrom Feb 19, 2025
Merged
Revert "lib.types.attrsWith: remove failing test"#382856hsjobeki merged 1 commit intoNixOS:masterfrom
hsjobeki merged 1 commit intoNixOS:masterfrom
Conversation
This reverts commit ce8f304. The problem was simply a typo (nestedTypes.elemType -> type.nestedTypes.elemType) ! And CI didn't run for lib in the orginal PR which is why it didn't get caught.
github-actions
bot
added
6.topic: module system
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1
Contributor
|
Looking good. I'll add some more tests in a seperate PR for other types as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ce8f304.
The problem was simply a typo (nestedTypes.elemType -> type.nestedTypes.elemType) ! And CI didn't run for lib in the orginal PR which is why it didn't get caught.
This leads the way for PRs like #382848 and #375084 to also introduce similar tests.
Things done
nix-build lib/tests/release.nixAdd a 👍 reaction to pull requests you find important.