Skip to content

python310/python311: fix failing tests with openssl >= 3.4#382794

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tvbeat:python311-failing-tests
Feb 19, 2025
Merged

python310/python311: fix failing tests with openssl >= 3.4#382794
mweinelt merged 1 commit intoNixOS:staging-nextfrom
tvbeat:python311-failing-tests

Conversation

@lblasc
Copy link
Contributor

@lblasc lblasc commented Feb 17, 2025 •
edited
Loading

Backport fix from upstream to resolve failing test of python311Packages.trio and some other packages as well.

see: python/cpython#127361

 > ----------------------------- Captured stdout call -----------------------------
       > ssl_echo_serve_sync got unexpected error: [SYS] unknown error (_ssl.c:2706)
       > =========================== short test summary info ============================
       > FAILED src/trio/_tests/test_ssl.py::test_ssl_client_basics[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_checkpoints[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_send_all_empty_string[tls13] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_ssl_client_basics[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_full_duplex_basics[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_checkpoints[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > FAILED src/trio/_tests/test_ssl.py::test_send_all_empty_string[tls12] - ExceptionGroup: Exceptions from Trio nursery (1 sub-exception)
       > ===== 7 failed, 733 passed, 38 skipped, 47 deselected, 2 xfailed in 5.34s ======

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 17, 2025
@lblasc lblasc requested review from mweinelt and vcunat February 17, 2025 10:46
@nix-owners nix-owners bot requested a review from natsukium February 17, 2025 10:47
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 17, 2025
SuperSandro2000
SuperSandro2000 reviewed Feb 17, 2025
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Feb 17, 2025
View reviewed changes
@lblasc lblasc force-pushed the python311-failing-tests branch from d341693 to 28ad38e Compare February 17, 2025 14:36
@mweinelt mweinelt self-assigned this Feb 17, 2025
@mweinelt
Copy link
Member

mweinelt commented Feb 17, 2025

We need a seaprate patch ported to 3.10 as well.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 18, 2025
@lblasc lblasc force-pushed the python311-failing-tests branch from 28ad38e to 964b572 Compare February 18, 2025 21:32
@lblasc lblasc changed the title python311: fix failing tests with openssl >= 3.4 python310/python311: fix failing tests with openssl >= 3.4 Feb 18, 2025
@lblasc
Copy link
Contributor Author

lblasc commented Feb 18, 2025

Pushed the patch for 3.10

mweinelt
mweinelt reviewed Feb 18, 2025
View reviewed changes
pkgs/development/interpreters/python/cpython/default.nix
] ++ optionals (pythonAtLeast "3.11" && pythonOlder "3.12") [
(fetchpatch {
url = "https://github.com/python/cpython/commit/f4b31edf2d9d72878dab1f66a36913b5bcc848ec.patch";
sha256 = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";
Copy link
Member

@mweinelt mweinelt Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";
hash = "sha256-w7zZMp0yqyi4h5oG8sK4z9BwNEkqg4Ar+en3nlWcxh0=";

@mweinelt mweinelt merged commit 5cf26c9 into NixOS:staging-next Feb 19, 2025
33 of 35 checks passed
@lblasc lblasc deleted the python311-failing-tests branch February 19, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@natsukium natsukium Awaiting requested review from natsukium

Assignees

@mweinelt mweinelt

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lblasc @mweinelt @SuperSandro2000 @wegank