libarchive: work around Darwin weirdness#382403
Closed
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
Closed
libarchive: work around Darwin weirdness#382403reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
Conversation
63d4212 to
3db1a26
Compare
Darwin will sometimes start adding the `com.apple.provenance` xattr to files, which breaks some of libarchive’s tests. See libarchive/libarchive#2510
3db1a26 to
d8e1fa7
Compare
This was referenced May 21, 2025
Member
|
I've found the root cause of the issue and submitted libarchive/libarchive#2636 which has been merged. I think we should apply it in #409300. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darwin will sometimes start adding the
com.apple.provenancexattr to files, which breaks some of libarchive’s tests.See libarchive/libarchive#2510
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.