Skip to content

libarchive: work around Darwin weirdness#382403

Closed
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode:push-xlxvmlvpqppn
Closed

libarchive: work around Darwin weirdness#382403
reckenrode wants to merge 1 commit intoNixOS:stagingfrom
reckenrode:push-xlxvmlvpqppn

Conversation

@reckenrode
Copy link
Contributor

Darwin will sometimes start adding the com.apple.provenance xattr to files, which breaks some of libarchive’s tests.

See libarchive/libarchive#2510

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 15, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 15, 2025
@nix-owners nix-owners bot requested a review from jcumming February 15, 2025 20:05
Darwin will sometimes start adding the `com.apple.provenance` xattr to
files, which breaks some of libarchive’s tests.

See libarchive/libarchive#2510
@zhaofengli
Copy link
Member

I've found the root cause of the issue and submitted libarchive/libarchive#2636 which has been merged. I think we should apply it in #409300.

@vcunat vcunat closed this May 28, 2025
@reckenrode reckenrode deleted the push-xlxvmlvpqppn branch November 15, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants