android-tools: 35.0.1 -> 35.0.2#382382
Closed
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Comment on lines
+61
to
+62
| # android-tools uses libusb API that has not been released yet | ||
| # use newer bundled libusb until the new libusb release arrive |
Contributor
There was a problem hiding this comment.
Can we include a link to relevant upstream (whether android-tools or libusb) discussions here? And if it's known yet what version of libusb will ship the relevant API, calling out that specific version here might be useful.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Contributor
|
Note that I encountered a severe issue with the previous version of this package (35.0.1), which may still be present in 35.0.2, see the discussion here: nmeum/android-tools#144 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nmeum/android-tools/releases/tag/35.0.2
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.