Skip to content

python312Packages.textnets: fix build on darwin, python312Packages.blis: fallback to generic architecure when needed#382088

Merged
NickCao merged 2 commits intoNixOS:masterfrom
GaetanLepage:blis
Feb 14, 2025
Merged

python312Packages.textnets: fix build on darwin, python312Packages.blis: fallback to generic architecure when needed#382088
NickCao merged 2 commits intoNixOS:masterfrom
GaetanLepage:blis

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 14, 2025 •
edited
Loading

Things done

  • python312Packages.blis: fallback to generic architecure when needed
  • python312Packages.textnets: fix build on darwin

cc @jboynyc @NickCao

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 14, 2025
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Feb 14, 2025
@nix-owners nix-owners bot requested review from NickCao and jboynyc February 14, 2025 16:21
jboynyc
jboynyc approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jboynyc jboynyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

NickCao
NickCao reviewed Feb 14, 2025
View reviewed changes
@GaetanLepage GaetanLepage force-pushed the blis branch 3 times, most recently from c77da8b to 75a6a51 Compare February 14, 2025 21:49
@GaetanLepage GaetanLepage changed the title python312Packages.textnets: fix build on darwin, python312Packages.blis: mark as broken on aarch64-linux and x86_64-darwin python312Packages.textnets: fix build on darwin, python312Packages.blis: fallback to generic architecure when needed Feb 14, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382088 --skip-package-regex .*private-gpt --skip-package-regex .*llama-index-readers

x86_64-linux

✅ 70 packages built:
  • python312Packages.blis
  • python312Packages.blis.dist
  • python312Packages.fastai
  • python312Packages.fastai.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-index.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.spacy
  • python312Packages.spacy-lookups-data
  • python312Packages.spacy-lookups-data.dist
  • python312Packages.spacy-transformers
  • python312Packages.spacy-transformers.dist
  • python312Packages.spacy.dist
  • python312Packages.textacy
  • python312Packages.textacy.dist
  • python312Packages.textnets
  • python312Packages.textnets.dist
  • python312Packages.thinc
  • python312Packages.thinc.dist
  • python313Packages.blis
  • python313Packages.blis.dist
  • tts
  • tts.dist

aarch64-linux

⏩ 6 packages marked as broken and skipped:
  • python312Packages.llama-index
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index.dist
✅ 62 packages built:
  • python312Packages.blis
  • python312Packages.blis.dist
  • python312Packages.fastai
  • python312Packages.fastai.dist
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.spacy
  • python312Packages.spacy-lookups-data
  • python312Packages.spacy-lookups-data.dist
  • python312Packages.spacy-transformers
  • python312Packages.spacy-transformers.dist
  • python312Packages.spacy.dist
  • python312Packages.textacy
  • python312Packages.textacy.dist
  • python312Packages.textnets
  • python312Packages.textnets.dist
  • python312Packages.thinc
  • python312Packages.thinc.dist
  • python313Packages.blis
  • python313Packages.blis.dist

x86_64-darwin

✅ 68 packages built:
  • python312Packages.blis
  • python312Packages.blis.dist
  • python312Packages.fastai
  • python312Packages.fastai.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-index.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.spacy
  • python312Packages.spacy-lookups-data
  • python312Packages.spacy-lookups-data.dist
  • python312Packages.spacy-transformers
  • python312Packages.spacy-transformers.dist
  • python312Packages.spacy.dist
  • python312Packages.textacy
  • python312Packages.textacy.dist
  • python312Packages.textnets
  • python312Packages.textnets.dist
  • python312Packages.thinc
  • python312Packages.thinc.dist
  • python313Packages.blis
  • python313Packages.blis.dist

aarch64-darwin

✅ 70 packages built:
  • python312Packages.blis
  • python312Packages.blis.dist
  • python312Packages.fastai
  • python312Packages.fastai.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-index.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.spacy
  • python312Packages.spacy-lookups-data
  • python312Packages.spacy-lookups-data.dist
  • python312Packages.spacy-transformers
  • python312Packages.spacy-transformers.dist
  • python312Packages.spacy.dist
  • python312Packages.textacy
  • python312Packages.textacy.dist
  • python312Packages.textnets
  • python312Packages.textnets.dist
  • python312Packages.thinc
  • python312Packages.thinc.dist
  • python313Packages.blis
  • python313Packages.blis.dist
  • tts
  • tts.dist

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 14, 2025

Command: nixpkgs-review pr 382088 --skip-package-regex .*private-gpt --skip-package-regex .*llama-index-readers

Skipped a few packages because they are hanging forever on darwin.

@NickCao NickCao merged commit 5553a77 into NixOS:master Feb 14, 2025
66 of 67 checks passed
@GaetanLepage GaetanLepage deleted the blis branch February 14, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

+1 more reviewer

@jboynyc jboynyc jboynyc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @jboynyc @NickCao