Skip to content

python3Packages.boxx: fix build#382056

Merged
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:python-boxx
Feb 14, 2025
Merged

python3Packages.boxx: fix build#382056
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:python-boxx

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Feb 14, 2025

  • fn dependency is no longer required
  • run tests only on Linux because xvfb is not available on other platforms

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- fn dependency is no longer required
- run tests only on Linux because xvfb is not available on other platforms
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 14, 2025
@prusnak prusnak merged commit e325ea9 into NixOS:master Feb 14, 2025
21 of 24 checks passed
@prusnak prusnak deleted the python-boxx branch February 14, 2025 14:02
@prusnak prusnak mentioned this pull request Feb 14, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 14, 2025
@nix-owners nix-owners bot requested a review from lucasew February 14, 2025 14:07
@ruro
Copy link
Contributor

ruro commented Feb 14, 2025

I am curious, are you actually using boxx/bpycv for anything?

As you've probably noticed, these packages aren't currently in a good place and AFAIK, neither upstream nor the current nixpkgs maintainer @lucasew are interested in supporting them.

I was originally planning to fix the build and tests in #380403 just like you did (and I did "kind of" fix the tests for boxx), but bpycv (the "main" package among this set of packages) is still fundamentally broken, because it is unsupported on modern versions of blender.

Following the discussion with the current nixpkgs maintainer in #379872, we decided that we might as well just remove these packages (#380443). I think that unless you are actively using boxx and/or bpycv, then removing these packages might still be preferable.

Thoughts?

@prusnak
Copy link
Member Author

prusnak commented Feb 14, 2025

I think that unless you are actively using boxx and/or bpycv, then removing these packages might still be preferable.

Thoughts?

I am not using them. I guess we can remove them if nobody use them.

@lucasew
Copy link
Contributor

lucasew commented Feb 15, 2025

@prusnak
Copy link
Member Author

prusnak commented Feb 15, 2025

Interesting! https://hydra.nixos.org/eval/1811921?filter=bpycv&compare=1811844&full=

what exactly is interesting? this pr fixed the build of boxx and also bpycv because boxx is its dependency

@ruro
Copy link
Contributor

ruro commented Feb 15, 2025

AFAIK, the build for bpycv itself currently succeeds only because its tests are performed in a separate derivation (instead of checkPhase). While the package itself technically "builds" after boxx tests were removed, it is still fundamentally broken due to some changes in the python API in Blender v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants