Skip to content

Comments

pcl: 1.13.0 -> 1.15.0-rc1, fix, cleanup#382027

Merged
NickCao merged 8 commits intoNixOS:masterfrom
GaetanLepage:pcl
Feb 14, 2025
Merged

pcl: 1.13.0 -> 1.15.0-rc1, fix, cleanup#382027
NickCao merged 8 commits intoNixOS:masterfrom
GaetanLepage:pcl

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Feb 14, 2025 •
edited
Loading

Things done

  • pcl: move to by-name
  • pcl: cleanup
  • pcl: 1.13.0 -> 1.15.0-rc1
  • pcl: add GaetanLepage as maintainer
  • pcl: mark as broken on darwin
  • rtabmap: move to by-name
  • rtabmap: cleanup
  • rtabmap: mark as broken

cc @marius851000

Changelog: https://github.com/PointCloudLibrary/pcl/blob/pcl-1.14.1/CHANGES.md

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 14, 2025
@GaetanLepage GaetanLepage changed the title pcl: 1.13.0 -> 1.14.1, fix, cleanup pcl: 1.13.0 -> 1.15.0-rc1, fix, cleanup Feb 14, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 14, 2025

I bumped pcl all the way to 1.15.0-rc1 as 1.14.0 does not build successfully.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382027

x86_64-linux

❌ 1 package failed to build:
  • rtabmap
✅ 2 packages built:
  • cloudcompare
  • pcl

aarch64-linux

❌ 1 package failed to build:
  • rtabmap
✅ 2 packages built:
  • cloudcompare
  • pcl

x86_64-darwin

❌ 1 package failed to build:
  • pcl

aarch64-darwin

❌ 1 package failed to build:
  • pcl

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Feb 14, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Feb 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382027

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • rtabmap
✅ 2 packages built:
  • cloudcompare
  • pcl

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • rtabmap
✅ 2 packages built:
  • cloudcompare
  • pcl

@GaetanLepage GaetanLepage mentioned this pull request Feb 14, 2025
Merged
13 tasks
NickCao
NickCao approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed commit by commit, diff LGTM.

@NickCao NickCao merged commit 10d412d into NixOS:master Feb 14, 2025
38 of 39 checks passed
@GaetanLepage GaetanLepage deleted the pcl branch February 14, 2025 23:51
@FliegendeWurst FliegendeWurst mentioned this pull request May 13, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @NickCao