nixos/pocket-id: init, pocket-id: init at 0.45.0#381867
Merged
marcusramberg merged 2 commits intoNixOS:masterfrom Apr 4, 2025
Merged
nixos/pocket-id: init, pocket-id: init at 0.45.0#381867marcusramberg merged 2 commits intoNixOS:masterfrom
marcusramberg merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
gepbird
force-pushed
the
pocket-id-init
branch
from
f4389d2 to
b8535fb
Compare
github-actions
bot
added
10.rebuild-darwin: 1
gepbird
force-pushed
the
pocket-id-init
branch
from
b8535fb to
99921f0
Compare
gepbird
changed the title
gepbird
force-pushed
the
pocket-id-init
branch
from
99921f0 to
cb0d948
Compare
gepbird
changed the title
gepbird
force-pushed
the
pocket-id-init
branch
from
cb0d948 to
1ed7902
Compare
gepbird
changed the title
gepbird
force-pushed
the
pocket-id-init
branch
from
1ed7902 to
7650475
Compare
gepbird
changed the title
gepbird
force-pushed
the
pocket-id-init
branch
from
7650475 to
3914cc9
Compare
gepbird
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
h7x4
added
8.has: module (new)
gepbird
force-pushed
the
pocket-id-init
branch
from
3914cc9 to
658cae8
Compare
gepbird
changed the title
gepbird
changed the title
gepbird
changed the title
gepbird
changed the title
gepbird
changed the title
Contributor
|
Using the package and module in my own flake for a few days, everything works well! (thanks @gepbird for pointing me to it, it is exactly what I needed!) Can't wait to see this merged |
gepbird
changed the title
ceedubs
approved these changes
Mar 21, 2025
Contributor
ceedubs
left a comment
ceedubs
left a comment
There was a problem hiding this comment.
Got a chance to try this and it's working great for me too!
wegank
added
the
12.approvals: 1
Contributor
|
@gepbird is your latest change working for you okay? I realized that 106c717 worked great for me but with 2e98a58 I'm getting an error about undefined not being a function in |
gepbird
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gepbird
changed the title
gepbird
changed the title
wegank
added
the
2.status: merge conflict
Co-authored-by: ymstnt <[email protected]> s: 0.42.1 -> 0.44.0 s: 0.44.0 -> 0.45.0
ofborg
bot
removed
the
2.status: merge conflict
Contributor
Author
|
Fixed merge conflict with #380990 |
Co-authored-by: ymstnt <[email protected]>
ceedubs
approved these changes
Apr 3, 2025
Contributor
|
Change lgtm, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a package and a NixOS module for Pocket ID, an OIDC auth provider.
We did some extra testing on our server using this module, works well so far.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.