canon-cups-ufr2: Rework build script with RPM spec#381315
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Feb 27, 2025
Merged
canon-cups-ufr2: Rework build script with RPM spec#381315GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
|
Any news on this? I'd like to re-enable my printer's drivers 🙂 |
I was tempted to ask the same question, but I'm not sure if I can read the patch workflow correctly (e.g. things like this patch being only targeted to the stable / 25.05 branch). |
pkgs/by-name/ca/canon-cups-ufr2/replace_incorrect_int_with_char.patch
Outdated
Show resolved
Hide resolved
Strongly inspired by the AUR package [1], this commit removes most manual build and install commands in favor of reusing the RPM spec file. With the rework and a small patch, cngplp now builds and is installed correctly. Previously, we would skip building cngplp, resulting in broken symlinks in the output folder. [1]: https://aur.archlinux.org/packages/cnrdrvcups-lb Fixes NixOS#380572
Contributor
Author
|
Thanks for looking over this. I combined the |
Contributor
|
GaetanLepage
approved these changes
Feb 27, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strongly inspired by the AUR package 1, this commit removes most manual build and install commands in favor of reusing the RPM spec file.
With the rework and a small patch, cngplp now builds and is installed correctly. Previously, we would skip building cngplp, resulting in broken symlinks in the output folder.
Fixes #380572
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.