Skip to content

haskell.compiler.ghc902: remove at 9.0.2#381265

Merged
wolfgangwalther merged 3 commits intoNixOS:masterfrom
sternenseemann:ghc-9.0.2-removal
Sep 7, 2025
Merged

haskell.compiler.ghc902: remove at 9.0.2#381265
wolfgangwalther merged 3 commits intoNixOS:masterfrom
sternenseemann:ghc-9.0.2-removal

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Feb 11, 2025

Let's drop everyone's least favorite GHC version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Feb 11, 2025
@nix-owners nix-owners bot requested a review from maralorn February 11, 2025 20:22
@sternenseemann sternenseemann mentioned this pull request Feb 11, 2025
Closed
11 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 11, 2025
maralorn
maralorn approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think we should do something like: https://md.darmstadt.ccc.de/FZwe_M9GQwWVnYfO0U4qJA

@sternenseemann
Copy link
Member Author

sternenseemann commented Feb 12, 2025

Agreed, that would be preferrable.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 14, 2025
@sternenseemann sternenseemann marked this pull request as draft June 2, 2025 13:59
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 12, 2025
wolfgangwalther
wolfgangwalther reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should proceed with this now, too.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 4, 2025
This was referenced Sep 5, 2025
Merged
Merged
wolfgangwalther
wolfgangwalther reviewed Sep 5, 2025
View reviewed changes
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Sep 5, 2025

I rebased this branch and solved merge conflicts.

@wolfgangwalther wolfgangwalther marked this pull request as ready for review September 5, 2025 12:50
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 5, 2025
wolfgangwalther
wolfgangwalther approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sternenseemann @wolfgangwalther
haskell.compiler.ghc902: remove at 9.0.2
f8560ad 
Let's drop everyone's least favorite GHC version.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 7, 2025
@wolfgangwalther
doc/release-notes: move all GHC related release notes in one place
3273094 
Also remove the minor version for GHCJS, similar to the others.
@nix-owners nix-owners bot requested review from cdepillabout and guibou September 7, 2025 09:33
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Sep 7, 2025

Also moved all the release notes related to GHC into one place.

Since this causes no rebuilds other than dropping the targeted GHC version, I'm confident that the changes are correct.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Sep 7, 2025
@wolfgangwalther wolfgangwalther merged commit 182ca24 into NixOS:master Sep 7, 2025
31 of 35 checks passed
@sternenseemann sternenseemann deleted the ghc-9.0.2-removal branch September 7, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@maralorn maralorn maralorn approved these changes

@guibou guibou Awaiting requested review from guibou

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sternenseemann @wolfgangwalther @emilazy @maralorn @wegank