ci/eval/compare: Ignore null packages#381262
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Feb 12, 2025
Merged
Conversation
infinisil
requested review from
GaetanLepage,
JohnRTitor and
wolfgangwalther
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
github-actions
bot
added
10.rebuild-darwin: 0
CI can fail to evaluate if a package is null: https://github.com/NixOS/nixpkgs/actions/runs/13209876145/job/36881335314?pr=380228
infinisil
force-pushed
the
null-packages
branch
from
098cbb6 to
799273b
Compare
eljamm
approved these changes
Feb 11, 2025
Contributor
eljamm
left a comment
eljamm
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
eljamm
added
the
12.approvals: 2
13 tasks
JohnRTitor
reviewed
Feb 12, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Question: does trace output the string in stderr or stdout?
If it shows it in stderr, checks will fail after #381266 (comment)
Member
Author
|
@JohnRTitor It's a separate eval. The maintainers are evaluated independently from the packages :) |
eljamm
added
12.approvals: 3+
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI can fail to evaluate if a package is null:
https://github.com/NixOS/nixpkgs/actions/runs/13209876145/job/36881335314?pr=380228
Should fix pings for xanmod, ping @eljamm, thanks for the report in #378595 (comment) :)
Things done
This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.