Skip to content

ntopng: fix build#381214

Merged
bjornfor merged 2 commits intoNixOS:masterfrom
bjornfor:fix-ntopng
Feb 11, 2025
Merged

ntopng: fix build#381214
bjornfor merged 2 commits intoNixOS:masterfrom
bjornfor:fix-ntopng

Conversation

@bjornfor
Copy link
Contributor

Things done

  • ndpi: 4.12 -> 4.10
  • ntopng: fix after noBrokenSymlinks

Fixes #380866

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Downgrade ndpi to fix building ntopng, which is the only user of this
library. (Note that ndpi 4.11 doesn't exist.)

Fixes: 63c1ea9 ("ndpi: 4.10 -> 4.12")
(A plain revert fails because of treewide changes.)

Ref. NixOS#380866
@bjornfor bjornfor requested a review from Ramblurr February 11, 2025 16:14
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 11, 2025
Copy link
Contributor

@Ramblurr Ramblurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--------- Report for 'x86_64-linux' ---------
2 packages built:
ndpi ntopng

built ntopng is working for me, many thanks @bjornfor

@bjornfor bjornfor merged commit 6675fab into NixOS:master Feb 11, 2025
26 of 27 checks passed
@bjornfor bjornfor deleted the fix-ntopng branch February 11, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: ntopng

2 participants