Skip to content

llvmPackages.libc: use clang by default#381065

Merged
RossComputerGuy merged 1 commit intoNixOS:masterfrom
RossComputerGuy:feat/llvm-libc-clang
Feb 12, 2025
Merged

llvmPackages.libc: use clang by default#381065
RossComputerGuy merged 1 commit intoNixOS:masterfrom
RossComputerGuy:feat/llvm-libc-clang

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Feb 11, 2025

Things done

Alternative to #375330.

Makes things buildable without pkgsLLVM.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label Feb 11, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 11, 2025
@alyssais
Copy link
Member

alyssais commented Feb 11, 2025

Seems fine. Do we expect the problem this is working around to be solved at some point in the future?

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented Feb 11, 2025

Do we expect the problem this is working around to be solved at some point in the future?

Not sure, it depends on GCC adding gnu::naked for aarch64.

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented Feb 11, 2025

Relevant bugzilla issue here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77882

@alyssais
Copy link
Member

alyssais commented Feb 11, 2025

Might be nice to mention that in a comment?

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented Feb 11, 2025

Done

@RossComputerGuy RossComputerGuy merged commit c3ca768 into NixOS:master Feb 12, 2025
26 of 27 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/llvm-libc-clang branch February 12, 2025 02:53
@wolfgangwalther wolfgangwalther mentioned this pull request Apr 4, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@dtzWill dtzWill Awaiting requested review from dtzWill

@rrbutani rrbutani Awaiting requested review from rrbutani

@lovek323 lovek323 Awaiting requested review from lovek323

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RossComputerGuy @alyssais