python3Packages.pyasynchat: fix build on sandboxed Darwin#380538
Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom Jul 5, 2025
Merged
python3Packages.pyasynchat: fix build on sandboxed Darwin#380538wolfgangwalther merged 1 commit intoNixOS:stagingfrom
wolfgangwalther merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
6.topic: python
nixpkgs-ci
bot
added
the
9.needs: reviewer
Contributor
|
Looks reasonable, but please change the target branch to |
nixpkgs-ci
bot
removed
the
9.needs: reviewer
al3xtjames
force-pushed
the
pyasynchat-darwin
branch
from
739c58c to
17fda22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the tests fail:
https://gist.github.com/al3xtjames/edd6170880bd43709b055ea12ae2be64
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.