Skip to content

Revert 376988#379615

Merged
roberth merged 3 commits intomasterfrom
revert-376988
Feb 5, 2025
Merged

Revert 376988#379615
roberth merged 3 commits intomasterfrom
revert-376988

Conversation

@roberth
Copy link
Member

@roberth roberth commented Feb 5, 2025

#376988 caused unnecessary disruption for users, causing them to apply unnecessary workarounds that have a lot of potential to linger in the ecosystem. (e.g. unnecessary { system = ... } attrset)

The purpose of this revert is only to end the disruption. A revert is not a value judgement, but I'd like to acknowledge that it is annoying, but that annoyance measures favorably against the annoyance experienced by ecosystem.

We'd welcome a carefully managed transition with deprecation warnings, and taking into account the feedback that was provided.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: nixos-container Imperative and declarative systemd-nspawn containers labels Feb 5, 2025
@nix-owners nix-owners bot requested a review from Ericson2314 February 5, 2025 13:39
@roberth
Copy link
Member Author

roberth commented Feb 5, 2025

Eval / Process failure is unrelated (and a fairly young check)

@yuyuyureka
Copy link
Contributor

@wolfgangwalther: have a look at master...yuyuyureka:nixpkgs:nixpkgs-unelaborated-platforms for a way to re-use the definitions of the hostPlatform option in a new option exposing the unelaborated platform. Not saying it's perfect, but maybe something to start with :)

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther: have a look at master...yuyuyureka:nixpkgs:nixpkgs-unelaborated-platforms for a way to re-use the definitions of the hostPlatform option in a new option exposing the unelaborated platform. Not saying it's perfect, but maybe something to start with :)

Thank you for the suggestion. I think this is another variant of the first thing I tried in eec2100. See also the discussion around #379411 (comment) related to it.

Currently we are evaluating a different approach in #380005.

brianmcgillion added a commit to brianmcgillion/ghaf that referenced this pull request Feb 8, 2025
These upstream pulls revert an issue that breaks the hostPlatform
determination during eval and build.

NixOS/nixpkgs#379615
NixOS/nixpkgs#379802

Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion added a commit to brianmcgillion/ghaf that referenced this pull request Feb 8, 2025
These upstream pulls revert an issue that breaks the hostPlatform
determination during eval and build.

NixOS/nixpkgs#379615
NixOS/nixpkgs#379802

Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion added a commit to brianmcgillion/ghaf that referenced this pull request Feb 8, 2025
These upstream pulls revert an issue that breaks the hostPlatform
determination during eval and build.

NixOS/nixpkgs#379615
NixOS/nixpkgs#379802

Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion added a commit to brianmcgillion/ghaf that referenced this pull request Feb 9, 2025
These upstream pulls revert an issue that breaks the hostPlatform
determination during eval and build.

NixOS/nixpkgs#379615
NixOS/nixpkgs#379802

Signed-off-by: Brian McGillion <[email protected]>
brianmcgillion added a commit to tiiuae/ghaf that referenced this pull request Feb 9, 2025
These upstream pulls revert an issue that breaks the hostPlatform
determination during eval and build.

NixOS/nixpkgs#379615
NixOS/nixpkgs#379802

Signed-off-by: Brian McGillion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nixos-container Imperative and declarative systemd-nspawn containers 8.has: module (update) This PR changes an existing module in `nixos/`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants