cc-wrapper: warn about cross-compile only with non-default #379593
Merged
emilazy merged 2 commits intoNixOS:stagingfrom Mar 11, 2025
Merged
cc-wrapper: warn about cross-compile only with non-default #379593emilazy merged 2 commits intoNixOS:stagingfrom
emilazy merged 2 commits intoNixOS:stagingfrom
Conversation
ofborg
bot
added
the
6.topic: cross-compilation
th7nder
changed the title
emilazy
reviewed
Feb 17, 2025
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Thanks; a lot of build systems seem to do this so I think this is a good change in principle. This will need the base branch changing to staging, as it will cause a mass rebuild of packages.
github-actions
bot
added
10.rebuild-darwin: 5001+
lf-
approved these changes
Mar 11, 2025
|
|
||
| declare -i n=0 | ||
| nParams=${#params[@]} | ||
| while (("$n" < "$nParams")); do |
Member
There was a problem hiding this comment.
fwiw it might be nicer to write this as a function that uses shift for this, but w/e, I am more in favour of getting this shipped than bikeshedding the way it is written.
emilazy
approved these changes
Mar 11, 2025
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Yeah let’s just get this in the next cycle since it’s happening imminently. Sorry for the slow review. Thanks for this!
11 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a follow-up to #323869.
Basically, show the warning if we're really setting the target for the cross-compilation different than the default platform.
It started to break some stuff in downstream Rust crates which depended on the stderr to check whether something is supported or not. Example issue: andresilva/polkadot.nix#36.
Investigation details are in the comments: #323869.
@emilazy @risicle
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.