apache-beam: 2.61.0 -> 2.62.0#379201
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Feb 6, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: python
apraga
force-pushed
the
apache-beam-2.62.0
branch
from
5a2376b to
a6b03b9
Compare
GaetanLepage
approved these changes
Feb 3, 2025
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
|
I would encourage you to report as many failures as possible upstream. |
apraga
force-pushed
the
apache-beam-2.62.0
branch
from
a6b03b9 to
b396e42
Compare
Contributor
Author
|
Good point. I'll create some issues and update the PR with the links. |
This was referenced Feb 4, 2025
apraga
force-pushed
the
apache-beam-2.62.0
branch
from
b396e42 to
734fe7a
Compare
Contributor
Author
|
@GaetanLepage issues have been opened upstream ! If the changes are OK with you, could you run If that pass, could you tag someone for reviewing/merging (as you see fit) ? Thanks :) |
GaetanLepage
reviewed
Feb 5, 2025
17 tasks
apraga
force-pushed
the
apache-beam-2.62.0
branch
from
734fe7a to
2523640
Compare
Contributor
|
Contributor
Author
|
Thanks for the testing ! Are you okay with marking all 3.13 and all arch + darwin as broken ? |
GaetanLepage
reviewed
Feb 5, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
Also,
- Remove
with lib;inmeta propagatedBuildInputs->dependencies.
apraga
force-pushed
the
apache-beam-2.62.0
branch
from
2523640 to
c27ea0c
Compare
Contributor
Author
|
Updated with you corrections. Tests stlll pass on python312 x86_64 |
Contributor
|
Contributor
Thanks ! I'm diagnosing the remaining darwin failures. |
Contributor
Author
|
Please do ! (Though I did not know it was possible as it’s my PR !). |
GaetanLepage
force-pushed
the
apache-beam-2.62.0
branch
from
c27ea0c to
93517d2
Compare
Contributor
As I am a committer I can do that ;) |
GaetanLepage
force-pushed
the
apache-beam-2.62.0
branch
from
93517d2 to
698bb2d
Compare
ofborg
bot
added
the
2.status: merge conflict
GaetanLepage
force-pushed
the
apache-beam-2.62.0
branch
from
698bb2d to
d5eb4d9
Compare
ofborg
bot
removed
the
2.status: merge conflict
GaetanLepage
force-pushed
the
apache-beam-2.62.0
branch
from
d5eb4d9 to
6e5f23d
Compare
GaetanLepage
changed the title
Contributor
|
GaetanLepage
approved these changes
Feb 6, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
There was the staging-next merge in the meantime.
I was able to adapt the PR and apache-beam now builds fine on all four platforms.
Python 3.13 cannot be tested as some dependencies are broken there.
Thank you @apraga for dealing with this package !
13 tasks
Contributor
Author
|
You rocks !
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my attempt to update this infamous package. I have excluded more tests to make it work. At the moment:
3128 passed, 973 skipped, 6015 warnings
My motivation is to avoid letting this package rot and this commit should be a starting point for future work to improve this package. Maybe opening an issue to track that would be great ?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage nixpkgs_review.errors.NixpkgsReviewError: Failed to list packages: nix-env failed with exit code -9./result/bin/) : not applicable (sdk)@GaetanLepage for help and advice as promised !
Add a 👍 reaction to pull requests you find important.