Skip to content

[staging-next] python312Packages.mdformat-tables: fix dependencies#379033

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
ofalvai:mdtables-deps
Feb 5, 2025
Merged

[staging-next] python312Packages.mdformat-tables: fix dependencies#379033
vcunat merged 1 commit intoNixOS:staging-nextfrom
ofalvai:mdtables-deps

Conversation

@ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Feb 3, 2025

https://hydra.nixos.org/build/287351094/log/tail

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2025
@ethancedwards8
Copy link
Member

ethancedwards8 commented Feb 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 379033

aarch64-linux

❌ 4 packages failed to build:
  • python312Packages.mdformat-mkdocs
  • python312Packages.mdformat-mkdocs.dist
  • python313Packages.mdformat-mkdocs
  • python313Packages.mdformat-mkdocs.dist
✅ 12 packages built:
  • python312Packages.mdformat-beautysh
  • python312Packages.mdformat-beautysh.dist
  • python312Packages.mdformat-gfm
  • python312Packages.mdformat-gfm.dist
  • python312Packages.mdformat-tables
  • python312Packages.mdformat-tables.dist
  • python313Packages.mdformat-beautysh
  • python313Packages.mdformat-beautysh.dist
  • python313Packages.mdformat-gfm
  • python313Packages.mdformat-gfm.dist
  • python313Packages.mdformat-tables
  • python313Packages.mdformat-tables.dist

@ethancedwards8
Copy link
Member

ethancedwards8 commented Feb 3, 2025 

> Executing pythonRuntimeDepsCheck
       > Checking runtime dependencies for mdformat_mkdocs-4.1.1-py3-none-any.whl
       >   - mdformat>=0.7.19 not satisfied by version 0.7.18

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025
@vcunat vcunat merged commit 37f980f into NixOS:staging-next Feb 5, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarmutex polarmutex Awaiting requested review from polarmutex

@aldoborrero aldoborrero Awaiting requested review from aldoborrero

1 more reviewer

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ofalvai @ethancedwards8 @vcunat @wegank