nixos/tests/userborn: fix setting hostPlatform#378940
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Feb 3, 2025
Merged
nixos/tests/userborn: fix setting hostPlatform#378940wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
Thanks! |
roberth
reviewed
Feb 3, 2025
Comment on lines
+39
to
+40
| nixpkgs.hostPlatform = { | ||
| inherit (pkgs.stdenv.hostPlatform) system; |
Member
There was a problem hiding this comment.
Why would non-system attributes have to be dropped?
This change should not be required of anyone.
Contributor
Author
There was a problem hiding this comment.
Just to be clear: I have no stakes (or particular interest) in the original PR and was just looking for a quick fix for my tests. I have no objections to reverting the original PR and this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests broken by #376988
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.