Skip to content

python310Packages.pyasynchat: fix tests#378792

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
FliegendeWurst:pyasynchat-py310
Feb 5, 2025
Merged

python310Packages.pyasynchat: fix tests#378792
vcunat merged 1 commit intoNixOS:staging-nextfrom
FliegendeWurst:pyasynchat-py310

Conversation

@FliegendeWurst
Copy link
Member

Used methods added in Python 3.11.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 2, 2025
@vcunat
Copy link
Member

vcunat commented Feb 3, 2025

So many rebuilds? For this attribute you apparently need null and not empty string.

@FliegendeWurst
Copy link
Member Author

Oh, in that case this can just go into staging. Python 3.10 support is not that important.

(And I think it would need to use optionalAttrs, null is different from unset if I remember correctly.)

@FliegendeWurst FliegendeWurst changed the base branch from staging-next to staging February 3, 2025 11:24
@vcunat
Copy link
Member

vcunat commented Feb 3, 2025

null does work. I did test that (just eval for the hash). That's a generic thing somewhere deep, perhaps in stdenv.mkDerivation.

@vcunat
Copy link
Member

vcunat commented Feb 3, 2025

Some attributes have specific handling also for empty list or empty string, as it's ergonomic with lib.optional*, but apparently not this attribute (yet).

Used methods added in Python 3.11.
@FliegendeWurst FliegendeWurst changed the base branch from staging to staging-next February 3, 2025 11:46
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 3, 2025
@vcunat vcunat merged commit 01de9eb into NixOS:staging-next Feb 5, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants