nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 378096

Logs: https://github.com/theobori/nixpkgs-review-gha/actions/runs/13059562644

x86_64-linux

aarch64-linux

Diff LGTM.

Diff LGTM, but please split refactors and updates into separate commits

it's only a small "refactor". I didn't know that something so tiny had to be separated into commits.

Diff LGTM, but please split refactors and updates into separate commits

it's only a small "refactor". I didn't know that something so tiny had to be separated into commits.

I think it's just good practice to split different kinds of changes into different commits. Of course, for very small changes it's not that critical, but in general it makes it easier both to review a PR and to revert only parts of a PR later, in case that's necessary for whatever reason. In this case specifically I think that adding an updateScript and a changelog is different enough from a simple version bump, so splitting this into two commits would make sense to me...

I certainly agree wrt to splitting commits in general, especially for review-ability. But in this case, I was positively surprised, because the commit is still very readable (which is often not the case when mixing up changes, unfortunately) and the changes were written out in the PR description (so certainly not "lack of effort" either, which seems to happen so often...).

Thus, OK for me.