Conversation
|
Looks good to me. Your patch works and fixes video text filter in shotcut, thanks a lot for your first-time contribution! 🎉 |
|
Thank you. (You don't need to merge master until conflicts emerge, and then it's rather recommended to rebase instead.) Maybe the other applications (flowblade hikounomizu kdenlive krita synfigstudio) depending on mlt need to be checked additionally. The impact on darwin is also out of my scope. |
|
Sorry for that, I merged master in an attempt to get rid of the failed nixfmt_check. Now that I look again, I must admit that I don't understand if pango and gdkpixbuf should also be added buildInputs. Maybe we should make it an optional dependency? Then it will only affect shotcut. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| pango | ||
| gdk-pixbuf |
There was a problem hiding this comment.
These should go in buildInputs instead, indeed
|
Looking at the mlt newsfeed I'd rather try to make qtext work again and not pull in pango/gdk into that Qt thing. |
|
re-adding qt to mlt fixed the text filter bug, no need for pango/gdk, see #421788 |
This is to solve a problem in the shotcut package:
Attempting to add text to a movie resulted in this error in the shotcut Application log:
[Warning] [filter 0x2cd39390] QT or GTK modules required for text.
[Warning] [filter 0x36c70710] Unable to create text filter.
This can be traced to
https://github.com/mltframework/mlt/blob/2b650c65cb5e265864cda8c3eff91945d406c56e/src/modules/plus/filter_text.c#L213
which suggests that we either need 'qtext' or pango. I don't know what qtext is, so I've added pango to the mlt dependencies.
mlt's CMakeLists.txt has this:
The cmake configure log complains about the missing gdk-pixbuf.
So I have added gdk-pixbuf and pango to the dependencies. I've also set MOD_GDK=1 though this is already the default.
I've rebuilt my nixos system and this indeed solves the problem in Shotcut!
Ping shotcut maintainers: @woffs and @peti
I'm new to nixos. In particular I'm not sure if what I did is safe to do on Darwin.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.