spotify-player: 0.20.3 -> 0.20.4 by arminius-smh · Pull Request #377530 · NixOS/nixpkgs

arminius-smh · 2025-01-28T11:18:14Z

https://github.com/aome510/spotify-player/releases/tag/v0.20.4

lyric_finder feature was exchanged with lyric_finder crate

Things done

Add a 👍 reaction to pull requests you find important.

momeemt · 2025-01-29T14:58:35Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377530

`aarch64-darwin`

❌ 1 package failed to build:

spotify-player

arminius-smh · 2025-01-29T17:41:03Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377530

`x86_64-linux`

✅ 1 package built:

spotify-player

xyven1 · 2025-01-29T17:55:20Z

This change looks correct to me, but I would like to know why the darwin build is failing.

arminius-smh · 2025-01-29T19:44:45Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377530

`aarch64-darwin`

✅ 1 package built:

spotify-player

arminius-smh · 2025-01-29T19:46:09Z

Eh.... no idea, it works on my machine??

spotify-player compiled and works on my m2, with the new lyrics sync feature as well

Mic92/nixpkgs-review#368 would have probably been helpful

momeemt · 2025-02-04T15:07:50Z

Sorry for the late reply. I missed this pull request. I'm not sure because I just had a quick look, it seems that it requires cocoa to build spotify-player on aarch64-darwin (sandbox enabled).

logs/spotify-player-aarch64-darwin.log

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/8h5pcbda6jgsjfm9qjgisbrva82ynmcl-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/c4zlrhy0mcawvczx1r2n03wqi9b8vz9m-spotify-player-0.20.4-vendor.tar.gz
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Executing cargoSetupPostPatchHook
Validating consistency between /private/tmp/nix-build-spotify-player-0.20.4.drv-0/source/Cargo.lock and /private/tmp/nix-build-spotify-player-0.20.4.drv-0/spotify-player-0.20.4-vendor.tar.gz/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing cargoBuildHook
cargoBuildHook flags: -j 10 --target aarch64-apple-darwin --offline --profile release --no-default-features --features=rodio-backend\,media-control\,image\,daemon\,notify\,streaming\,sixel\,fzf
�[1m�[32m   Compiling�[0m libc v0.2.168
�[1m�[32m   Compiling�[0m proc-macro2 v1.0.92
�[1m�[32m   Compiling�[0m unicode-ident v1.0.14
�[1m�[32m   Compiling�[0m cfg-if v1.0.0
�[1m�[32m   Compiling�[0m autocfg v1.4.0
�[1m�[32m   Compiling�[0m scopeguard v1.2.0
�[1m�[32m   Compiling�[0m memchr v2.7.4
�[1m�[32m   Compiling�[0m log v0.4.22
�[1m�[32m   Compiling�[0m simd-adler32 v0.3.7
�[1m�[32m   Compiling�[0m smallvec v1.13.2
�[1m�[32m   Compiling�[0m foldhash v0.1.3
�[1m�[32m   Compiling�[0m equivalent v1.0.1
�[1m�[32m   Compiling�[0m allocator-api2 v0.2.21
�[1m�[32m   Compiling�[0m adler2 v2.0.0
�[1m�[32m   Compiling�[0m shlex v1.3.0
�[1m�[32m   Compiling�[0m miniz_oxide v0.8.0
�[1m�[32m   Compiling�[0m once_cell v1.20.2
�[1m�[32m   Compiling�[0m gimli v0.31.1
�[1m�[32m   Compiling�[0m core-foundation-sys v0.8.7
�[1m�[32m   Compiling�[0m object v0.36.5
�[1m�[32m   Compiling�[0m lock_api v0.4.12
�[1m�[32m   Compiling�[0m hashbrown v0.15.2
�[1m�[32m   Compiling�[0m fixedbitset v0.4.2
�[1m�[32m   Compiling�[0m rustc-demangle v0.1.24
�[1m�[32m   Compiling�[0m parking_lot_core v0.9.10
�[1m�[32m   Compiling�[0m indexmap v2.7.0
�[1m�[32m   Compiling�[0m quote v1.0.37
�[1m�[32m   Compiling�[0m pin-project-lite v0.2.15
�[1m�[32m   Compiling�[0m jobserver v0.1.32
�[1m�[32m   Compiling�[0m spin v0.9.8
�[1m�[32m   Compiling�[0m syn v2.0.90
�[1m�[32m   Compiling�[0m getrandom v0.2.15
�[1m�[32m   Compiling�[0m thread-id v4.2.2
�[1m�[32m   Compiling�[0m petgraph v0.6.5
�[1m�[32m   Compiling�[0m cc v1.2.4
�[1m�[32m   Compiling�[0m itoa v1.0.14
�[1m�[32m   Compiling�[0m bytes v1.9.0
�[1m�[32m   Compiling�[0m mio v1.0.3
�[1m�[32m   Compiling�[0m futures-core v0.3.31
�[1m�[32m   Compiling�[0m thiserror v1.0.69
�[1m�[32m   Compiling�[0m futures-sink v0.3.31
�[1m�[32m   Compiling�[0m addr2line v0.24.2
�[1m�[32m   Compiling�[0m socket2 v0.5.8
�[1m�[32m   Compiling�[0m slab v0.4.9
�[1m�[32m   Compiling�[0m fnv v1.0.7
�[1m�[32m   Compiling�[0m serde v1.0.216
�[1m�[32m   Compiling�[0m bitflags v2.6.0
�[1m�[32m   Compiling�[0m bitflags v1.3.2
�[1m�[32m   Compiling�[0m futures-channel v0.3.31
�[1m�[32m   Compiling�[0m core-foundation v0.9.4
�[1m�[32m   Compiling�[0m futures-io v0.3.31
�[1m�[32m   Compiling�[0m futures-task v0.3.31
�[1m�[32m   Compiling�[0m typenum v1.17.0
�[1m�[32m   Compiling�[0m pin-utils v0.1.0
�[1m�[32m   Compiling�[0m version_check v0.9.5
�[1m�[32m   Compiling�[0m tracing-core v0.1.33
�[1m�[32m   Compiling�[0m backtrace v0.3.74
�[1m�[32m   Compiling�[0m byteorder v1.5.0
�[1m�[32m   Compiling�[0m generic-array v0.14.7
�[1m�[32m   Compiling�[0m anyhow v1.0.94
�[1m�[32m   Compiling�[0m ring v0.17.8
�[1m�[32m   Compiling�[0m libm v0.2.11
�[1m�[32m   Compiling�[0m num-traits v0.2.19
�[1m�[32m   Compiling�[0m parking_lot v0.12.3
�[1m�[32m   Compiling�[0m rustversion v1.0.18
�[1m�[32m   Compiling�[0m subtle v2.6.1
�[1m�[32m   Compiling�[0m untrusted v0.9.0
�[1m�[32m   Compiling�[0m synstructure v0.13.1
�[1m�[32m   Compiling�[0m rand_core v0.6.4
�[1m�[32m   Compiling�[0m stable_deref_trait v1.2.0
�[1m�[32m   Compiling�[0m paste v1.0.15
�[1m�[32m   Compiling�[0m httparse v1.9.5
�[1m�[32m   Compiling�[0m const-oid v0.9.6
�[1m�[32m   Compiling�[0m crypto-common v0.1.6
�[1m�[32m   Compiling�[0m http v1.2.0
�[1m�[32m   Compiling�[0m rustls-pki-types v1.10.1
�[1m�[32m   Compiling�[0m zeroize v1.8.1
�[1m�[32m   Compiling�[0m cmake v0.1.52
�[1m�[32m   Compiling�[0m fs_extra v1.3.0
�[1m�[32m   Compiling�[0m dunce v1.0.5
�[1m�[32m   Compiling�[0m try-lock v0.2.5
�[1m�[32m   Compiling�[0m aws-lc-sys v0.23.1
�[1m�[32m   Compiling�[0m security-framework-sys v2.12.1
�[1m�[32m   Compiling�[0m writeable v0.5.5
�[1m�[32m   Compiling�[0m want v0.3.1
�[1m�[32m   Compiling�[0m litemap v0.7.4
�[1m�[32m   Compiling�[0m block-buffer v0.10.4
�[1m�[32m   Compiling�[0m either v1.13.0
�[1m�[32m   Compiling�[0m tower-service v0.3.3
�[1m�[32m   Compiling�[0m digest v0.10.7
�[1m�[32m   Compiling�[0m zerocopy-derive v0.7.35
�[1m�[32m   Compiling�[0m tokio-macros v2.4.0
�[1m�[32m   Compiling�[0m thiserror-impl v1.0.69
�[1m�[32m   Compiling�[0m serde_derive v1.0.216
�[1m�[32m   Compiling�[0m futures-macro v0.3.31
�[1m�[32m   Compiling�[0m zerofrom-derive v0.1.5
�[1m�[32m   Compiling�[0m tracing-attributes v0.1.28
�[1m�[32m   Compiling�[0m yoke-derive v0.7.5
�[1m�[32m   Compiling�[0m tokio v1.42.0
�[1m�[32m   Compiling�[0m zerocopy v0.7.35
�[1m�[32m   Compiling�[0m futures-util v0.3.31
�[1m�[32m   Compiling�[0m zerofrom v0.1.5
�[1m�[32m   Compiling�[0m zerovec-derive v0.10.3
�[1m�[32m   Compiling�[0m displaydoc v0.2.5
�[1m�[32m   Compiling�[0m tracing v0.1.41
�[1m�[32m   Compiling�[0m ppv-lite86 v0.2.20
�[1m�[32m   Compiling�[0m yoke v0.7.5
�[1m�[32m   Compiling�[0m rand_chacha v0.3.1
�[1m�[32m   Compiling�[0m rand v0.8.5
�[1m�[32m   Compiling�[0m icu_provider_macros v1.5.0
�[1m�[32m   Compiling�[0m zerovec v0.10.4
�[1m�[32m   Compiling�[0m aho-corasick v1.1.3
�[1m�[32m   Compiling�[0m lazy_static v1.5.0
�[1m�[32m   Compiling�[0m encoding_rs v0.8.35
�[1m�[32m   Compiling�[0m strsim v0.11.1
�[1m�[32m   Compiling�[0m regex-syntax v0.8.5
�[1m�[32m   Compiling�[0m tokio-util v0.7.13
�[1m�[32m   Compiling�[0m tinystr v0.7.6
�[1m�[32m   Compiling�[0m icu_locid_transform_data v1.5.0
�[1m�[32m   Compiling�[0m aws-lc-rs v1.11.1
�[1m�[32m   Compiling�[0m icu_locid v1.5.0
�[1m�[32m   Compiling�[0m ident_case v1.0.1
�[1m�[32m   Compiling�[0m darling_core v0.20.10
�[1m�[32m   Compiling�[0m icu_collections v1.5.0
�[1m�[32m   Compiling�[0m rustix v0.38.42
�[1m�[32m   Compiling�[0m icu_provider v1.5.0
�[1m�[32m   Compiling�[0m regex-automata v0.4.9
�[1m�[32m   Compiling�[0m icu_properties_data v1.5.0
�[1m�[32m   Compiling�[0m icu_locid_transform v1.5.0
�[1m�[32m   Compiling�[0m ryu v1.0.18
�[1m�[32m   Compiling�[0m icu_properties v1.5.1
�[1m�[32m   Compiling�[0m http-body v1.0.1
�[1m�[32m   Compiling�[0m darling_macro v0.20.10
�[1m�[32m   Compiling�[0m regex v1.11.1
�[1m�[32m   Compiling�[0m errno v0.3.10
�[1m�[32m   Compiling�[0m icu_normalizer_data v1.5.0
�[1m�[32m   Compiling�[0m utf8_iter v1.0.4
�[1m�[32m   Compiling�[0m utf16_iter v1.0.5
�[1m�[32m   Compiling�[0m write16 v1.0.0
�[1m�[32m   Compiling�[0m atomic-waker v1.1.2
�[1m�[32m   Compiling�[0m h2 v0.4.7
�[1m�[32m   Compiling�[0m darling v0.20.10
�[1m�[32m   Compiling�[0m icu_normalizer v1.5.0
�[1m�[32m   Compiling�[0m security-framework v2.11.1
�[1m�[32m   Compiling�[0m num-integer v0.1.46
�[1m�[32m   Compiling�[0m cpufeatures v0.2.16
�[1m�[32m   Compiling�[0m arrayvec v0.7.6
�[1m�[32m   Compiling�[0m percent-encoding v2.3.1
�[1m�[32m   Compiling�[0m bytemuck v1.20.0
�[1m�[32m   Compiling�[0m form_urlencoded v1.2.1
�[1m�[32m   Compiling�[0m idna_adapter v1.2.0
�[1m�[32m   Compiling�[0m mime v0.3.17
�[1m�[32m   Compiling�[0m protobuf v3.7.1
�[1m�[32m   Compiling�[0m serde_json v1.0.133
�[1m�[32m   Compiling�[0m hyper v1.5.1
�[1m�[32m   Compiling�[0m idna v1.0.3
�[1m�[32m   Compiling�[0m glob v0.3.1
�[1m�[32m   Compiling�[0m utf-8 v0.7.6
�[1m�[32m   Compiling�[0m clang-sys v1.8.1
�[1m�[32m   Compiling�[0m url v2.5.4
�[1m�[32m   Compiling�[0m hyper-util v0.1.10
�[1m�[32m   Compiling�[0m serde_urlencoded v0.7.1
�[1m�[32m   Compiling�[0m derive_builder_core v0.20.2
�[1m�[32m   Compiling�[0m rustls-pemfile v2.2.0
�[1m�[32m   Compiling�[0m http v0.2.12
�[1m�[32m   Compiling�[0m rustls v0.21.12
�[1m�[32m   Compiling�[0m new_debug_unreachable v1.0.6
�[1m�[32m   Compiling�[0m httpdate v1.0.3
�[1m�[32m   Compiling�[0m siphasher v0.3.11
�[1m�[32m   Compiling�[0m fastrand v2.3.0
�[1m�[32m   Compiling�[0m ipnet v2.10.1
�[1m�[32m   Compiling�[0m crossbeam-utils v0.8.21
�[1m�[32m   Compiling�[0m tempfile v3.14.0
�[1m�[32m   Compiling�[0m derive_builder_macro v0.20.2
�[1m�[32m   Compiling�[0m protobuf-support v3.7.1
�[1m�[32m   Compiling�[0m num-bigint v0.4.6
�[1m�[32m   Compiling�[0m rustls-webpki v0.101.7
�[1m�[32m   Compiling�[0m sct v0.7.1
�[1m�[32m   Compiling�[0m vergen-lib v0.1.5
�[1m�[32m   Compiling�[0m rustls v0.23.20
�[1m�[32m   Compiling�[0m system-configuration-sys v0.5.0
�[1m�[32m   Compiling�[0m powerfmt v0.2.0
�[1m�[32m   Compiling�[0m minimal-lexical v0.2.1
�[1m�[32m   Compiling�[0m home v0.5.9
�[1m�[32m   Compiling�[0m base64 v0.21.7
�[1m�[32m   Compiling�[0m base64ct v1.6.0
�[1m�[32m   Compiling�[0m nom v7.1.3
�[1m�[32m   Compiling�[0m which v4.4.2
�[1m�[32m   Compiling�[0m pem-rfc7468 v0.7.0
�[1m�[32m   Compiling�[0m deranged v0.3.11
�[1m�[32m   Compiling�[0m derive_builder v0.20.2
�[1m�[32m   Compiling�[0m h2 v0.3.26
�[1m�[32m   Compiling�[0m http-body v0.4.6
�[1m�[32m   Compiling�[0m http-body-util v0.1.2
�[1m�[32m   Compiling�[0m vergen v9.0.2
�[1m�[32m   Compiling�[0m libloading v0.8.6
�[1m�[32m   Compiling�[0m num_threads v0.1.7
�[1m�[32m   Compiling�[0m iana-time-zone v0.1.61
�[1m�[32m   Compiling�[0m base64 v0.22.1
�[1m�[32m   Compiling�[0m rustls v0.22.4
�[1m�[32m   Compiling�[0m time-core v0.1.2
�[1m�[32m   Compiling�[0m num-conv v0.1.0
�[1m�[32m   Compiling�[0m bindgen v0.70.1
�[1m�[32m   Compiling�[0m time v0.3.37
�[1m�[32m   Compiling�[0m chrono v0.4.39
�[1m�[32m   Compiling�[0m cexpr v0.6.0
�[1m�[32m   Compiling�[0m crossbeam-epoch v0.9.18
�[1m�[32m   Compiling�[0m tokio-rustls v0.24.1
�[1m�[32m   Compiling�[0m protobuf-parse v3.7.1
�[1m�[32m   Compiling�[0m hyper v0.14.31
�[1m�[32m   Compiling�[0m der v0.7.9
�[1m�[32m   Compiling�[0m sha1 v0.10.6
�[1m�[32m   Compiling�[0m itertools v0.13.0
�[1m�[32m   Compiling�[0m num-derive v0.4.2
�[1m�[32m   Compiling�[0m vergen-gitcl v1.0.2
�[1m�[32m   Compiling�[0m core-foundation v0.10.0
�[1m�[32m   Compiling�[0m rustc-hash v1.1.0
�[1m�[32m   Compiling�[0m rayon-core v1.12.1
�[1m�[32m   Compiling�[0m security-framework v3.0.1
�[1m�[32m   Compiling�[0m hyper-rustls v0.24.2
�[1m�[32m   Compiling�[0m spki v0.7.3
�[1m�[32m   Compiling�[0m system-configuration v0.5.1
�[1m�[32m   Compiling�[0m protobuf-codegen v3.7.1
�[1m�[32m   Compiling�[0m crossbeam-deque v0.8.6
�[1m�[32m   Compiling�[0m rustls-pemfile v1.0.4
�[1m�[32m   Compiling�[0m phf_shared v0.11.2
�[1m�[32m   Compiling�[0m phf_shared v0.10.0
�[1m�[32m   Compiling�[0m symphonia-core v0.5.4
�[1m�[32m   Compiling�[0m sha2 v0.10.8
�[1m�[32m   Compiling�[0m futures-executor v0.3.31
�[1m�[32m   Compiling�[0m inout v0.1.3
�[1m�[32m   Compiling�[0m malloc_buf v0.0.6
�[1m�[32m   Compiling�[0m num-bigint-dig v0.8.4
�[1m�[32m   Compiling�[0m webpki-roots v0.25.4
�[1m�[32m   Compiling�[0m heck v0.5.0
�[1m�[32m   Compiling�[0m native-tls v0.2.12
�[1m�[32m   Compiling�[0m sync_wrapper v0.1.2
�[1m�[32m   Compiling�[0m portable-atomic v1.10.0
�[1m�[32m   Compiling�[0m reqwest v0.11.27
�[1m�[32m   Compiling�[0m librespot-protocol v0.6.0
�[1m�[32m   Compiling�[0m objc v0.2.7
�[1m�[32m   Compiling�[0m cipher v0.4.4
�[1m�[32m   Compiling�[0m symphonia-metadata v0.5.4
�[1m�[32m   Compiling�[0m futures v0.3.31
�[1m�[32m   Compiling�[0m phf_generator v0.10.0
�[1m�[32m   Compiling�[0m phf_generator v0.11.2
�[1m�[32m   Compiling�[0m rustls-native-certs v0.8.1
�[1m�[32m   Compiling�[0m pkcs8 v0.10.2
�[1m�[32m   Compiling�[0m rustls-native-certs v0.7.3
�[1m�[32m   Compiling�[0m num-iter v0.1.45
�[1m�[32m   Compiling�[0m serde_path_to_error v0.1.16
�[1m�[32m   Compiling�[0m headers-core v0.3.0
�[1m�[32m   Compiling�[0m base64 v0.13.1
�[1m�[32m   Compiling�[0m system-configuration-sys v0.6.0
�[1m�[32m   Compiling�[0m objc-sys v0.3.5
�[1m�[32m   Compiling�[0m coreaudio-sys v0.2.16
�[1m�[32m   Compiling�[0m data-encoding v2.6.0
�[1m�[32m   Compiling�[0m oauth2 v4.4.2
�[1m�[32m   Compiling�[0m headers v0.4.0
�[1m�[32m   Compiling�[0m pkcs1 v0.7.5
�[1m�[32m   Compiling�[0m librespot-core v0.6.0
�[1m�[32m   Compiling�[0m phf_codegen v0.11.2
�[1m�[32m   Compiling�[0m string_cache_codegen v0.5.2
�[1m�[32m   Compiling�[0m webpki v0.22.4
�[1m�[32m   Compiling�[0m hmac v0.12.1
�[1m�[32m   Compiling�[0m signature v2.2.0
�[1m�[32m   Compiling�[0m core-graphics-types v0.1.3
�[1m�[32m   Compiling�[0m spinning_top v0.3.0
�[1m�[32m   Compiling�[0m futures-timer v3.0.3
�[1m�[32m   Compiling�[0m built v0.7.5
�[1m�[32m   Compiling�[0m no-std-compat v0.4.1
�[1m�[32m   Compiling�[0m nonzero_ext v0.3.0
�[1m�[32m   Compiling�[0m mac v0.1.1
�[1m�[32m   Compiling�[0m block v0.1.6
�[1m�[32m   Compiling�[0m aligned-vec v0.5.0
�[1m�[32m   Compiling�[0m signal-hook v0.3.17
�[1m�[32m   Compiling�[0m futf v0.1.5
�[1m�[32m   Compiling�[0m rav1e v0.7.1
�[1m�[32m   Compiling�[0m v_frame v0.3.8
�[1m�[32m   Compiling�[0m governor v0.6.3
�[1m�[32m   Compiling�[0m rsa v0.9.7
�[1m�[32m   Compiling�[0m tokio-native-tls v0.3.1
�[1m�[32m   Compiling�[0m pbkdf2 v0.12.2
�[1m�[32m   Compiling�[0m markup5ever v0.12.1
�[1m�[32m   Compiling�[0m librespot-oauth v0.6.0
�[1m�[32m   Compiling�[0m rayon v1.10.0
�[1m�[32m   Compiling�[0m symphonia-utils-xiph v0.5.4
�[1m�[32m   Compiling�[0m aes v0.8.4
�[1m�[32m   Compiling�[0m num-rational v0.4.2
�[1m�[32m   Compiling�[0m quick-xml v0.36.2
�[1m�[32m   Compiling�[0m tokio-stream v0.1.17
�[1m�[32m   Compiling�[0m uuid v1.11.0
�[1m�[32m   Compiling�[0m async-trait v0.1.83
�[1m�[32m   Compiling�[0m profiling-procmacros v1.0.16
�[1m�[32m   Compiling�[0m shannon v0.2.0
�[1m�[32m   Compiling�[0m signal-hook-registry v1.4.2
�[1m�[32m   Compiling�[0m sysinfo v0.31.4
�[1m�[32m   Compiling�[0m priority-queue v2.1.1
�[1m�[32m   Compiling�[0m crc32fast v1.4.2
�[1m�[32m   Compiling�[0m utf8parse v0.2.2
�[1m�[32m   Compiling�[0m precomputed-hash v0.1.1
�[1m�[32m   Compiling�[0m cpal v0.15.3
�[1m�[32m   Compiling�[0m make-cmd v0.1.0
�[1m�[32m   Compiling�[0m objc2-encode v4.0.3
�[1m�[32m   Compiling�[0m sixel-sys v0.3.1
�[1m�[32m   Compiling�[0m string_cache v0.8.7
�[1m�[32m   Compiling�[0m objc2 v0.5.2
�[1m�[32m   Compiling�[0m anstyle-parse v0.2.6
�[1m�[32m   Compiling�[0m flate2 v1.0.35
�[1m�[32m   Compiling�[0m profiling v1.0.16
�[1m�[32m   Compiling�[0m maybe-rayon v0.1.1
�[1m�[32m   Compiling�[0m av1-grain v0.2.3
�[1m�[32m   Compiling�[0m phf v0.11.2
�[1m�[32m   Compiling�[0m system-configuration v0.6.1
�[1m�[32m   Compiling�[0m coreaudio-rs v0.11.3
�[1m�[32m   Compiling�[0m hyper-tls v0.6.0
�[1m�[32m   Compiling�[0m tendril v0.4.3
�[1m�[32m   Compiling�[0m strum_macros v0.26.4
�[1m�[32m   Compiling�[0m rgb v0.8.50
�[1m�[32m   Compiling�[0m tokio-socks v0.5.2
�[1m�[32m   Compiling�[0m itertools v0.12.1
�[1m�[32m   Compiling�[0m arg_enum_proc_macro v0.3.4
�[1m�[32m   Compiling�[0m sync_wrapper v1.0.2
�[1m�[32m   Compiling�[0m simd_helpers v0.1.0
�[1m�[32m   Compiling�[0m mach2 v0.4.2
�[1m�[32m   Compiling�[0m colorchoice v1.0.3
�[1m�[32m   Compiling�[0m dispatch v0.2.0
�[1m�[32m   Compiling�[0m noop_proc_macro v0.3.0
�[1m�[32m   Compiling�[0m anstyle v1.0.10
�[1m�[32m   Compiling�[0m quick-error v2.0.1
�[1m�[32m   Compiling�[0m imgref v1.11.0
�[1m�[32m   Compiling�[0m foreign-types-shared v0.1.1
�[1m�[32m   Compiling�[0m bitstream-io v2.6.0
�[1m�[32m   Compiling�[0m is_terminal_polyfill v1.70.1
�[1m�[32m   Compiling�[0m anstyle-query v1.1.2
�[1m�[32m   Compiling�[0m dasp_sample v0.11.0
�[1m�[32m   Compiling�[0m weezl v0.1.8
�[1m�[32m   Compiling�[0m anstream v0.6.18
�[1m�[32m   Compiling�[0m strum v0.26.3
�[1m�[32m   Compiling�[0m loop9 v0.1.5
�[1m�[32m   Compiling�[0m foreign-types v0.3.2
�[1m�[32m   Compiling�[0m reqwest v0.12.9
�[1m�[32m   Compiling�[0m block2 v0.5.1
�[1m�[32m   Compiling�[0m signal-hook-mio v0.2.4
�[1m�[32m   Compiling�[0m symphonia-format-ogg v0.5.4
�[1m�[32m   Compiling�[0m symphonia-codec-vorbis v0.5.4
�[1m�[32m   Compiling�[0m symphonia-bundle-mp3 v0.5.4
�[1m�[32m   Compiling�[0m ctr v0.9.2
�[1m�[32m   Compiling�[0m objc_id v0.1.1
�[1m�[32m   Compiling�[0m avif-serialize v0.8.2
�[1m�[32m   Compiling�[0m toml_datetime v0.6.8
�[1m�[32m   Compiling�[0m serde_spanned v0.6.8
�[1m�[32m   Compiling�[0m foreign-types-macros v0.2.3
�[1m�[32m   Compiling�[0m html5ever v0.27.0
�[1m�[32m   Compiling�[0m mac-notification-sys v0.6.2
�[1m�[32m   Compiling�[0m dirs-sys-next v0.1.2
�[1m�[32m   Compiling�[0m fdeflate v0.3.7
�[1m�[32m   Compiling�[0m zune-inflate v0.2.54
�[1m�[32m   Compiling�[0m half v2.4.1
�[1m�[32m   Compiling�[0m byteorder-lite v0.1.0
�[1m�[32m   Compiling�[0m clap_lex v0.7.4
�[1m�[32m   Compiling�[0m color_quant v1.1.0
�[1m�[32m   Compiling�[0m winnow v0.6.20
�[1m�[32m   Compiling�[0m jpeg-decoder v0.3.1
�[1m�[32m   Compiling�[0m diff v0.1.13
�[1m�[32m   Compiling�[0m foreign-types-shared v0.3.1
�[1m�[32m   Compiling�[0m bit_field v0.10.2
�[1m�[32m   Compiling�[0m cfg_aliases v0.2.1
�[1m�[32m   Compiling�[0m zune-core v0.4.12
�[1m�[32m   Compiling�[0m regex-syntax v0.6.29
�[1m�[32m   Compiling�[0m lebe v0.5.2
�[1m�[32m   Compiling�[0m yansi v1.0.1
�[1m�[32m   Compiling�[0m exr v1.73.0
�[1m�[32m   Compiling�[0m pretty_assertions v1.4.1
�[1m�[32m   Compiling�[0m zune-jpeg v0.4.14
�[1m�[32m   Compiling�[0m regex-automata v0.1.10
�[1m�[32m   Compiling�[0m winit v0.30.5
�[1m�[32m   Compiling�[0m foreign-types v0.5.0
�[1m�[32m   Compiling�[0m toml_edit v0.22.22
�[1m�[32m   Compiling�[0m tiff v0.9.1
�[1m�[32m   Compiling�[0m gif v0.13.1
�[1m�[32m   Compiling�[0m clap_builder v4.5.23
�[1m�[32m   Compiling�[0m image-webp v0.2.0
�[1m�[32m   Compiling�[0m ravif v0.11.11
�[1m�[32m   Compiling�[0m png v0.17.15
�[1m�[32m   Compiling�[0m dirs-next v2.0.0
�[1m�[32m   Compiling�[0m objc-foundation v0.1.1
The following warnings were emitted during compilation:

�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: Warning: supplying the --target argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/Cocoa-36OD5SWBX3GHC.pcm': 'No such file or directory'
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: In file included from objc/notify.m:1:
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]:     1 | #import <Cocoa/Cocoa.h>
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]:       |  ~~~~~~~^
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/CoreServices-29W2JVV5LAS4I.pcm': 'No such file or directory'
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/Foundation-3V8ZUUVK3GAIY.pcm': 'No such file or directory'
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/ObjectiveC-3CJV0NKCYRQUI.pcm': 'No such file or directory'
�[1m�[33mwarning�[0m�[1m:�[0m [email protected]: 5 errors generated.

�[1m�[31merror�[0m�[1m:�[0m failed to run custom build command for `mac-notification-sys v0.6.2`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-spotify-player-0.20.4.drv-0/source/target/release/build/mac-notification-sys-106a7feb36e1f803/build-script-build` (exit status: 1)
  --- stdout
  OUT_DIR = Some(/private/tmp/nix-build-spotify-player-0.20.4.drv-0/source/target/aarch64-apple-darwin/release/build/mac-notification-sys-4f07f2a16a1af539/out)
  OPT_LEVEL = Some(3)
  TARGET = Some(aarch64-apple-darwin)
  HOST = Some(aarch64-apple-darwin)
  cargo:rerun-if-env-changed=CC_aarch64-apple-darwin
  CC_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CC_aarch64_apple_darwin
  CC_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = Some(/nix/store/x25662zlrvzy1aavv8y5vrk40bj8c8hr-clang-wrapper-19.1.6/bin/cc)
  RUSTC_WRAPPER = None
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(true)
  cargo:rerun-if-env-changed=MACOSX_DEPLOYMENT_TARGET
  MACOSX_DEPLOYMENT_TARGET = Some(11.3)
  cargo:rerun-if-env-changed=CFLAGS_aarch64-apple-darwin
  CFLAGS_aarch64-apple-darwin = None
  cargo:rerun-if-env-changed=CFLAGS_aarch64_apple_darwin
  CFLAGS_aarch64_apple_darwin = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  CARGO_ENCODED_RUSTFLAGS = Some(-C�target-feature=-crt-static)
  cargo:warning=Warning: supplying the --target argument to a nix-wrapped compiler may not work correctly - cc-wrapper is currently not designed with multi-target compilers in mind. You may want to use an un-wrapped compiler instead.
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/Cocoa-36OD5SWBX3GHC.pcm': 'No such file or directory'
  cargo:warning=In file included from objc/notify.m:1:
  cargo:warning=objc/notify.h:1:9: fatal error: could not build module 'Cocoa'
  cargo:warning=    1 | #import <Cocoa/Cocoa.h>
  cargo:warning=      |  ~~~~~~~^
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/CoreServices-29W2JVV5LAS4I.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/Foundation-3V8ZUUVK3GAIY.pcm': 'No such file or directory'
  cargo:warning=error: unable to open output file '/homeless-shelter/.cache/clang/ModuleCache/3OZ5QVIT6YKPQ/ObjectiveC-3CJV0NKCYRQUI.pcm': 'No such file or directory'
  cargo:warning=5 errors generated.

  --- stderr


  error occurred in cc-rs: Command env -u IPHONEOS_DEPLOYMENT_TARGET LC_ALL="C" "/nix/store/x25662zlrvzy1aavv8y5vrk40bj8c8hr-clang-wrapper-19.1.6/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "--target=arm64-apple-macosx11.3" "-Wall" "-Wextra" "-fmodules" "-Wno-deprecated-declarations" "-mmacos-version-min=11.3" "-o" "/private/tmp/nix-build-spotify-player-0.20.4.drv-0/source/target/aarch64-apple-darwin/release/build/mac-notification-sys-4f07f2a16a1af539/out/54532c69c7c8f551-notify.o" "-c" "objc/notify.m" with args cc did not execute successfully (status code exit status: 1).


�[1m�[33mwarning�[0m�[1m:�[0m build failed, waiting for other jobs to finish...

arminius-smh · 2025-02-04T19:56:52Z

Ah right. I now get the same error with sandbox=true added, sorry I didn't know about it, thanks for the added comment

I added the cocoa framework, which wasn't enough since I needed another fix for building mac-notification-sys, like already done here:

nixpkgs/pkgs/tools/misc/starship/default.nix

Lines 42 to 45 in be02d86

    
             # tries to access HOME only in aarch64-darwin environment when building mac-notification-sys 
        
             preBuild = lib.optionalString (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64) '' 
        
               export HOME=$TMPDIR 
        
             '';

or here:

nixpkgs/pkgs/by-name/gh/ghostie/package.nix

Lines 46 to 48 in c6e957d

    
             preBuild = lib.optionalString stdenv.hostPlatform.isDarwin '' 
        
               export HOME=$(mktemp -d) 
        
             '';

So I basically copied that over and now it builds on aarch64-darwin with sandbox=true as well, if you could confirm @momeemt I'd be grateful in case I have missed something else on my machine since I never use nix on darwin, or darwin for that matter

edit: actually, not sure if the extra darwin dependency is even necessary, it builds without it and only the fix but not sure if it is needed at runtime anyway, I can't find any documentation on the darwin stuff at all and am just doing guess work

momeemt · 2025-02-05T13:33:40Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377530

`aarch64-darwin`

✅ 1 package built:

spotify-player

momeemt

Thanks for the fix, it looks like it builds properly in the sandbox environment. LGTM!

arminius-smh · 2025-02-06T09:52:36Z

Ups sorry I had to address the merge conflict caused by treewide: migrate to fetchCargoVendor, batch 1 which I missed that wasn't in my branch yet

pkgs/by-name/sp/spotify-player/package.nix

xyven1

This looks good.

nix-owners bot requested review from 71zenith, dit7ya and xyven1 January 28, 2025 11:26

71zenith approved these changes Jan 31, 2025

View reviewed changes

wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 1, 2025

arminius-smh force-pushed the spotify-player-update branch from 0fda477 to 046fe79 Compare February 4, 2025 19:56

wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025

momeemt approved these changes Feb 5, 2025

View reviewed changes

momeemt added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 5, 2025

arminius-smh force-pushed the spotify-player-update branch 2 times, most recently from bcc1b14 to 64545ae Compare February 6, 2025 09:52

khaneliman reviewed Feb 6, 2025

View reviewed changes

pkgs/by-name/sp/spotify-player/package.nix Outdated Show resolved Hide resolved

spotify-player: 0.20.3 -> 0.20.4

ab315b1

arminius-smh force-pushed the spotify-player-update branch from 64545ae to ab315b1 Compare February 6, 2025 17:38

wegank removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Feb 7, 2025

xyven1 approved these changes Feb 12, 2025

View reviewed changes

wegank added the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Feb 14, 2025

wegank merged commit 0fb03d3 into NixOS:master Feb 14, 2025
28 checks passed

arminius-smh deleted the spotify-player-update branch April 30, 2025 21:24

Uh oh!

Comments

Conversation

arminius-smh commented Jan 28, 2025

Things done

Uh oh!

momeemt commented Jan 29, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

arminius-smh commented Jan 29, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

xyven1 commented Jan 29, 2025

Uh oh!

arminius-smh commented Jan 29, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

arminius-smh commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

momeemt commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arminius-smh commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

momeemt commented Feb 5, 2025

nixpkgs-review result

aarch64-darwin

Uh oh!

momeemt left a comment

Choose a reason for hiding this comment

Uh oh!

arminius-smh commented Feb 6, 2025

Uh oh!

Uh oh!

xyven1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

`nixpkgs-review` result

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`aarch64-darwin`

arminius-smh commented Jan 29, 2025 •

edited

Loading

momeemt commented Feb 4, 2025 •

edited

Loading

arminius-smh commented Feb 4, 2025 •

edited

Loading

`nixpkgs-review` result

`aarch64-darwin`