Skip to content

Revert "llvmPackages.tblgen: add missing lldb-tblgen"#377162

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
emilazy:push-llsopypknkon
Jan 27, 2025
Merged

Revert "llvmPackages.tblgen: add missing lldb-tblgen"#377162
vcunat merged 1 commit intoNixOS:stagingfrom
emilazy:push-llsopypknkon

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jan 26, 2025

Breaks Darwin bootstrap:

CMake Error at /tmp/nix-build-llvm-tblgen-19.1.7.drv-0/llvm-tblgen-src-19.1.7/lldb/test/CMakeLists.txt:197 (message):
  LLDB test suite requires libc++, but it is currently disabled.  Please add
  `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via
  `LLDB_INCLUDE_TESTS=OFF`.

It’s probably not too hard to fix but I don’t really understand the details of this derivation and it’s blocking Darwin stdenv builds with a few days to go until the next cycle, so reverting for now.

This reverts commit d175d8a.

cc @pwaller (not part of the org, can’t request for review)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Breaks Darwin bootstrap:

    CMake Error at /tmp/nix-build-llvm-tblgen-19.1.7.drv-0/llvm-tblgen-src-19.1.7/lldb/test/CMakeLists.txt:197 (message):
      LLDB test suite requires libc++, but it is currently disabled.  Please add
      `libcxx` to `LLVM_ENABLE_RUNTIMES` or disable tests via
      `LLDB_INCLUDE_TESTS=OFF`.

It’s probably not too hard to fix but I don’t really understand the
details of this derivation and it’s blocking Darwin `stdenv` builds
with a few days to go until the next cycle, so reverting for now.

This reverts commit d175d8a.
@github-actions github-actions bot added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label Jan 26, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 27, 2025
@vcunat vcunat merged commit ca8d8ef into NixOS:staging Jan 27, 2025
25 of 27 checks passed
@pwaller
Copy link
Contributor

pwaller commented Jan 27, 2025

Ack cc, thanks.

@emilazy emilazy deleted the push-llsopypknkon branch January 27, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants